You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/04 15:35:14 UTC
[GitHub] [spark] yaooqinn opened a new pull request #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
yaooqinn opened a new pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
The `spark.sql.session.timeZone` config can accept any string value including invalid time zone ids, then it will fail other queries that rely on the time zone. We should do the value checking in the set phase and fail fast if the zone value is invalid.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
improve configuration
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
yes, will fail fast if the value is a wrong timezone id
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add ut
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#discussion_r387765158
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -348,4 +348,24 @@ class SQLConfSuite extends QueryTest with SharedSparkSession {
}
check(config2)
}
+
+ test("spark.sql.session.timeZone should only accept valid zone id") {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "MIT")
+ assert(sql(s"set ${SQLConf.SESSION_LOCAL_TIMEZONE.key}").head().getString(1) === "MIT")
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "America/Chicago")
+ assert(sql(s"set ${SQLConf.SESSION_LOCAL_TIMEZONE.key}").head().getString(1) ===
+ "America/Chicago")
+
+ intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "pst")
+ }
+ intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "GMT+8:00")
+ }
+ intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "Asia/shanghai")
+ }
+
+
Review comment:
remove extra blank lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594637580
**[Test build #119322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119322/testReport)** for PR 27792 at commit [`fa7a372`](https://github.com/apache/spark/commit/fa7a3720baa51b33189af8d50bb6702fcfe20098).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594638438
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594845156
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594996260
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27792: [SPARK-31038][SQL] Add
checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-595185778
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27792: [SPARK-31038][SQL] Add
checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594860351
**[Test build #119322 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119322/testReport)** for PR 27792 at commit [`fa7a372`](https://github.com/apache/spark/commit/fa7a3720baa51b33189af8d50bb6702fcfe20098).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594996260
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594845176
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119315/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594861925
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594996262
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24095/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#discussion_r387816365
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1654,6 +1660,8 @@ object SQLConf {
.doc("""The ID of session local timezone, e.g. "GMT", "America/Los_Angeles", etc.""")
.version("")
.stringConf
+ .checkValue(isValidTimezone, "The time zone should obey rules managed by" +
+ " java.time.zone.ZoneRulesProvider")
Review comment:
This is still unclear, maybe just say: `Cannot resolve the give timezone with ZoneId.of(_, ZoneId.SHORT_IDS)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-595074137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119357/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594613019
**[Test build #119315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119315/testReport)** for PR 27792 at commit [`72dce3c`](https://github.com/apache/spark/commit/72dce3c7a85ac39462270a49ae238b0353eddca6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-595074126
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594638447
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24059/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594607491
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24053/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-595074126
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594845176
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119315/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27792: [SPARK-31038][SQL] Add
checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594619261
cc @cloud-fan @maropu, thanks for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#discussion_r388016145
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -348,4 +348,22 @@ class SQLConfSuite extends QueryTest with SharedSparkSession {
}
check(config2)
}
+
+ test("spark.sql.session.timeZone should only accept valid zone id") {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "MIT")
+ assert(sql(s"set ${SQLConf.SESSION_LOCAL_TIMEZONE.key}").head().getString(1) === "MIT")
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "America/Chicago")
+ assert(sql(s"set ${SQLConf.SESSION_LOCAL_TIMEZONE.key}").head().getString(1) ===
+ "America/Chicago")
+
+ intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "pst")
+ }
+ intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "GMT+8:00")
+ }
+ intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "Asia/shanghai")
Review comment:
Please check the error messages here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594996262
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24095/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594607491
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24053/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594861935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119322/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594995921
**[Test build #119357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119357/testReport)** for PR 27792 at commit [`641b74b`](https://github.com/apache/spark/commit/641b74b4a3987476961e047103a33a03d8743bca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#discussion_r388016145
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -348,4 +348,22 @@ class SQLConfSuite extends QueryTest with SharedSparkSession {
}
check(config2)
}
+
+ test("spark.sql.session.timeZone should only accept valid zone id") {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "MIT")
+ assert(sql(s"set ${SQLConf.SESSION_LOCAL_TIMEZONE.key}").head().getString(1) === "MIT")
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "America/Chicago")
+ assert(sql(s"set ${SQLConf.SESSION_LOCAL_TIMEZONE.key}").head().getString(1) ===
+ "America/Chicago")
+
+ intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "pst")
+ }
+ intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "GMT+8:00")
+ }
+ intercept[IllegalArgumentException] {
+ spark.conf.set(SQLConf.SESSION_LOCAL_TIMEZONE.key, "Asia/shanghai")
Review comment:
Please check the error messages here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27792: [SPARK-31038][SQL] Add
checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594843188
**[Test build #119315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119315/testReport)** for PR 27792 at commit [`72dce3c`](https://github.com/apache/spark/commit/72dce3c7a85ac39462270a49ae238b0353eddca6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594861925
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-595074137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119357/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594607465
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27792: [SPARK-31038][SQL] Add
checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594637580
**[Test build #119322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119322/testReport)** for PR 27792 at commit [`fa7a372`](https://github.com/apache/spark/commit/fa7a3720baa51b33189af8d50bb6702fcfe20098).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#discussion_r387764964
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1654,6 +1656,8 @@ object SQLConf {
.doc("""The ID of session local timezone, e.g. "GMT", "America/Los_Angeles", etc.""")
.version("")
.stringConf
+ .checkValue(z => Try { DateTimeUtils.getZoneId(z) }.isSuccess, "The timeZone should obey" +
Review comment:
can we create a method in `object SQLConf`?
```
private def isValidTimezone...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594845156
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27792: [SPARK-31038][SQL] Add
checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-595073303
**[Test build #119357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119357/testReport)** for PR 27792 at commit [`641b74b`](https://github.com/apache/spark/commit/641b74b4a3987476961e047103a33a03d8743bca).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594638438
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594861935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119322/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594638447
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24059/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27792: [SPARK-31038][SQL]
Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594607465
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27792: [SPARK-31038][SQL] Add
checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594995921
**[Test build #119357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119357/testReport)** for PR 27792 at commit [`641b74b`](https://github.com/apache/spark/commit/641b74b4a3987476961e047103a33a03d8743bca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27792: [SPARK-31038][SQL] Add
checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#issuecomment-594613019
**[Test build #119315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119315/testReport)** for PR 27792 at commit [`72dce3c`](https://github.com/apache/spark/commit/72dce3c7a85ac39462270a49ae238b0353eddca6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27792:
[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27792: [SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone
URL: https://github.com/apache/spark/pull/27792#discussion_r387814355
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -75,6 +77,10 @@ object SQLConf {
}
}
+ def isValidTimezone(zone: String): Boolean = {
Review comment:
can we move it closer to where it's used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org