You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by xe...@xml.apache.org on 2004/07/19 16:33:39 UTC

[jira] Closed: (XERCESC-1238) DomWriter does not pass MemoryManager to XMLFormatter

Message:

   The following issue has been closed.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/XERCESC-1238

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XERCESC-1238
    Summary: DomWriter does not pass MemoryManager to XMLFormatter
       Type: Bug

     Status: Closed
   Priority: Minor
 Resolution: FIXED

    Project: Xerces-C++
 Components: 
             DOM
   Versions:
             2.3.0

   Assignee: 
   Reporter: Michael Kopp

    Created: Fri, 2 Jul 2004 4:53 AM
    Updated: Mon, 19 Jul 2004 7:33 AM

Description:
file: dom/impl/DomWriterImpl.cpp
function: bool DOMWriterImpl::writeNode

The first thing it does is to create a XMLFormatter. It uses its assigned MemoryManager, but fails to pass it on into the Constructor, this XMLFormatter itself will use the global MemoryManager instead of the supplied one.
the line:

fFormatter = new (fMemoryManager) XMLFormatter(fEncodingUsed
                              ,fDocumentVersion
                              ,destination
                              ,XMLFormatter::NoEscapes
                              ,XMLFormatter::UnRep_CharRef);

should be changed to:

fFormatter = new (fMemoryManager) XMLFormatter(fEncodingUsed
                              ,fDocumentVersion
                              ,destination
                              ,XMLFormatter::NoEscapes
                              ,XMLFormatter::UnRep_CharRef,
                              fMemoryManager);


It is a minor thing but in our case a performance bottleneck.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org