You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/07/06 15:34:29 UTC
[GitHub] zeppelin pull request #1141: [Bugfix] Wrong return value of HDFSFileInterpre...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1141
[Bugfix] Wrong return value of HDFSFileInterpreter completion.
### What is this PR for?
This PR fixes auto competion of HDFSFileInterpreter.
### What type of PR is it?
Bug Fix
### How should this be tested?
Please refer to test case.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin bugfix/HDFSFileInterpreterCompletion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1141
----
commit 05f0a7d4c37e4f3bb3d3b067e1124a3f65b931a1
Author: astroshim <hs...@nflabs.com>
Date: 2016-07-06T15:14:53Z
bugfix HDFSFileInterpreter completion
commit b30610b1f8327511c4435fada4a31dc7f0dbc3b3
Author: astroshim <hs...@nflabs.com>
Date: 2016-07-06T15:17:19Z
fix code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1141: [Bugfix] Wrong return value of HDFSFileInterpreter com...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1141
CI's passed. Thank you @bzz and @cloverhearts !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1141: [Bugfix] Wrong return value of HDFSFileInterpreter com...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1141
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1141: [Bugfix] Wrong return value of HDFSFileInterpreter com...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1141
@bzz
in my opnnion..
this reason.
```
[ERROR] HDFSFileInterpreter.java[314:75] (whitespace) WhitespaceAfter: ',' is not followed by whitespace.
```
https://s3.amazonaws.com/archive.travis-ci.org/jobs/142795525/log.txt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1141: [Bugfix] Wrong return value of HDFSFileInterpre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1141: [Bugfix] Wrong return value of HDFSFileInterpreter com...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1141
@cloverhearts Thank you very much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1141: [Bugfix] Wrong return value of HDFSFileInterpreter com...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1141
Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1141: [Bugfix] Wrong return value of HDFSFileInterpreter com...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1141
Can this PR going to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1141: [Bugfix] Wrong return value of HDFSFileInterpreter com...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1141
CI fails due to https://github.com/npm/npm/issues/13284#issuecomment-230799479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---