You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/20 14:54:36 UTC

[GitHub] [iceberg] nastra commented on a diff in pull request #5051: Build: Quicker project evaluation + write evaluated project version to `build/`

nastra commented on code in PR #5051:
URL: https://github.com/apache/iceberg/pull/5051#discussion_r901764250


##########
build.gradle:
##########
@@ -60,9 +60,14 @@ dependencyRecommendations {
   propertiesFile file: file('versions.props')
 }
 
+def projectVersion = getProjectVersion()

Review Comment:
   moving this out of `allprojects` makes sense but we're not reading from `$buildDir/version.txt` anywhere I believe



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org