[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

[BryanCutler <gi...@git.apache.org>]

Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17922#discussion_r126769478
  
    --- Diff: python/pyspark/ml/tests.py ---
    @@ -832,6 +860,96 @@ def test_logistic_regression(self):
             except OSError:
                 pass
     
    +    def logistic_regression_check_thresholds(self):
    +        self.assertIsInstance(
    +            LogisticRegression(threshold=0.5, thresholds=[0.5, 0.5]),
    +            LogisticRegressionModel
    +        )
    +
    +        self.assertRaisesRegexp(
    +            ValueError,
    +            "Logistic Regression getThreshold found inconsistent.*$",
    +            LogisticRegression, threshold=0.42, thresholds=[0.5, 0.5]
    +        )
    +
    +    def test_binomial_logistic_regression_bounds(self):
    --- End diff --
    
    I agree this is probably overkill for testing this.  The functionality is already in Scala and should be tested there, here in python we are just setting the parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org