You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/03/09 14:11:46 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #237: acknowledge use of netty derived code
pjfanning opened a new pull request, #237:
URL: https://github.com/apache/incubator-pekko/pull/237
relates to #231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #237: acknowledge use of netty derived code
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #237:
URL: https://github.com/apache/incubator-pekko/pull/237#discussion_r1131336873
##########
legal/pekko-actor-jar-license.txt:
##########
@@ -214,3 +214,9 @@ pekko-actor contains code from scala-collection-compat in the `org.apache.pekko.
which has written by the Scala-Lang team under an Apache 2.0 license.
Copyright (c) 2002-2023 EPFL
Copyright (c) 2011-2023 Lightbend, Inc.
+
+---------------
+
+pekko-actor contains code from Netty in `org.apache.pekko.io.dns.DnsSettings.scala`
Review Comment:
INAL, maybe we can add a header in that file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #237: acknowledge use of netty derived code
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #237:
URL: https://github.com/apache/incubator-pekko/pull/237#issuecomment-1462500167
lgtm，let's merge this then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #237: acknowledge use of netty derived code
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #237:
URL: https://github.com/apache/incubator-pekko/pull/237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #237: acknowledge use of netty derived code
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #237:
URL: https://github.com/apache/incubator-pekko/pull/237#discussion_r1131378559
##########
legal/pekko-actor-jar-license.txt:
##########
@@ -214,3 +214,9 @@ pekko-actor contains code from scala-collection-compat in the `org.apache.pekko.
which has written by the Scala-Lang team under an Apache 2.0 license.
Copyright (c) 2002-2023 EPFL
Copyright (c) 2011-2023 Lightbend, Inc.
+
+---------------
+
+pekko-actor contains code from Netty in `org.apache.pekko.io.dns.DnsSettings.scala`
Review Comment:
The netty code is Apache licensed so our file header covers that already. We still need to acknowledge it the main license and notice files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org