DO NOT REPLY [Bug 36306] New: - Collection of fixes to address Checkstyle complaints

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36306>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36306

           Summary: Collection of fixes to address Checkstyle complaints
           Product: Struts
           Version: 1.3.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Unknown
        AssignedTo: dev@struts.apache.org
        ReportedBy: fzammetti@omnytex.com


This deasl only with core...

Attached is a rather large patch to resolve a good number of Checkstyle 
complaints (1,462 resolved).  Also attached is a zip archive containing the 
source directory structure with just package.html files... I couldn't figure 
out how to make the patch include new files, and I also frankly didn't recall 
which files I added, so the existing ones are simply overwritten, they are 
identical though.

Here is a rundown of what was resolved... note that no functional code changes 
were made, and the only actual code that was changed was to resolve some of 
the lines that were longer than 80 characters...

Based on TRUNK source code as of 12:00pm EST on 8/22/2005:
Total Checkstyle complaints (using existing ruleset): 4,760

* Added package.html to packages that were missing them.  I tried to write
  a small yet reasonable description in each, but I'd appreciate anyone
  that can checking them and/or expanding on them as appropriate.
  Complaints resolved: 12.
  
* Converted tabs to spaces in all source files where that applied.  
  Complaints resolved: 1054.

* Added a newline at the end of all source files that didn't have one.
  This required converting a number of files from Unix/MAC format to DOS 
  since Checkstyle apparently didn't recognize the newline for those files.
  Only a couple, and I believe they were all in the chain package or
  sub-package thereof.
  Complaints resolved: 17.
  
* Removed unused imports.
  Complaints resolved: 15.
 
* Moved brackets to resolve "Array brackets at illegal position"
  complaints.
  Complaints resolved: 46.
  
* Fixed all "Unclosed HTML tag found" complaints.
  Complaints resolved: 11.
  
* Fixed all "; is not followed by whitespace" complaints.
  Complaints resolved: 62.
  
* Fixed all "- is not preceded with whitespace".
  Complaints resolved: 18.
  
* Fixed all "== is not preceded with whitespace".
  Complaints resolved: 49.

* Line lengths greater than 80 characters.  These were the only actual
  code changes, and it was just breaking lines up, no code was
  FUNCTIONALLY changed, by this bullet point or any other.  There was a
  total of 671 of these, 493 remain.
  Complaints resolved: 178.

Checkstyle complaints remaining after above patches applied: 3,298.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org