You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "RNHTTR (via GitHub)" <gi...@apache.org> on 2023/02/27 14:58:19 UTC
[GitHub] [airflow] RNHTTR opened a new pull request, #29785: Update database-erd-ref.rst
RNHTTR opened a new pull request, #29785:
URL: https://github.com/apache/airflow/pull/29785
The language as is seems to suggest that the database isn't backwards compatible; it should be backwards compatible, but it nonetheless probably shouldn't be directly accessed.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RNHTTR commented on pull request #29785: Update database-erd-ref.rst
Posted by "RNHTTR (via GitHub)" <gi...@apache.org>.
RNHTTR commented on PR #29785:
URL: https://github.com/apache/airflow/pull/29785#issuecomment-1446973140
I thought _all_ Airflow components in a particular major release were [more or less protected by semver](https://airflow.apache.org/docs/apache-airflow/stable/release-process.html). If the database schema is not necessarily protected by semver, does it make sense to add a caveat to https://airflow.apache.org/docs/apache-airflow/stable/release-process.html to indicate as much?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29785: Update database-erd-ref.rst
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29785:
URL: https://github.com/apache/airflow/pull/29785#issuecomment-1446936124
> The language as is seems to suggest that the database isn't backwards compatible; it should be backwards compatible, but it nonetheless probably shouldn't be directly accessed.
Because that's what it is. We WANT to make backwards incompatible DB changes in the future (sometimes even in patchlevel releases). This is a clear intention we have.
It was intentional and very clear and strong statement that you absolutely should not rely on database structure. We might decide to drop a field or rename it at any time. And we want to be very clear about it.
This is also very clearly explained in the new page (that will be up in 2.6) that clearly explains what is (and what is not) public API interface that you can rely on - and the Database Structure is very clearly and specifically put in the "do not rely on it".
Why do you thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RNHTTR commented on pull request #29785: Update database-erd-ref.rst
Posted by "RNHTTR (via GitHub)" <gi...@apache.org>.
RNHTTR commented on PR #29785:
URL: https://github.com/apache/airflow/pull/29785#issuecomment-1448302491
There's an xkcd for everything!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RNHTTR closed pull request #29785: Update database-erd-ref.rst
Posted by "RNHTTR (via GitHub)" <gi...@apache.org>.
RNHTTR closed pull request #29785: Update database-erd-ref.rst
URL: https://github.com/apache/airflow/pull/29785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29785: Update database-erd-ref.rst
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29785:
URL: https://github.com/apache/airflow/pull/29785#issuecomment-1447003499
> I thought _all_ Airflow components in a particular major release were [more or less protected by semver](https://airflow.apache.org/docs/apache-airflow/stable/release-process.html). If the database schema is not necessarily protected by semver, does it make sense to add a caveat to https://airflow.apache.org/docs/apache-airflow/stable/release-process.html to indicate as much?
This is exactly what https://github.com/apache/airflow/blob/main/docs/apache-airflow/public-airflow-interface.rst is addressing - it explains what IS and waht IS NOT covered by our intent of backwards compatibility. Database had never been intended to be backwards compatible, we just never clearly stated it.
In general it is impossible to keep "ideal backwards comatibility" because no such thing exists. As extensively discussed in this devlist thread: https://lists.apache.org/thread/1by8ko8jrrp1xwxt5781bwn2tokxjodl, very nicely explained by [Hyrum's Law](https://www.hyrumslaw.com/) and very succintly explained by this XKCD comic:
So with https://github.com/apache/airflow/blob/main/docs/apache-airflow/public-airflow-interface.rs we will attempt to explain what is supposed to be seen as "Public interface of Airflow" and what is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org