You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/02/03 12:07:13 UTC

[GitHub] [dolphinscheduler-website] hongshuboy opened a new pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

hongshuboy opened a new pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667


   separate usage into multiple sections
   use icon in process definitions page instead of a screenshot
   add an example for one or two simple actual task
   add images for sql task demo and use appropriate language screenshot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy edited a comment on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy edited a comment on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1038209375






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1028942212


   **Screenshots in English and Chinese**
   
   ![sql-eng](https://user-images.githubusercontent.com/40915465/152342770-f6821aad-6182-4cca-a850-d7054ff89845.png)
   ![sql](https://user-images.githubusercontent.com/40915465/152342883-5669e878-3c00-448d-809a-c4bc3eee939f.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1037932831






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1037933304


   ![sql](https://user-images.githubusercontent.com/40915465/153745747-1a50a013-aa65-4a08-aa2e-b079901516e4.png)
   ![sql 2](https://user-images.githubusercontent.com/40915465/153745748-cad460ab-41b9-48a3-8ad3-a9bec623e08b.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1033831326


   copy that, I will submit the update in a few days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#discussion_r805323293



##########
File path: docs/en-us/2.0.0/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,43 @@
 # SQL
 
-- Drag in the toolbar![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)Task node into the drawing board
-- Non-query SQL function: edit non-query SQL task information, select non-query for sql type, as shown in the figure below:
- <p align="center">
-  <img src="/img/sql-en.png" width="80%" />
-</p>
+## Overview
 
-- Query SQL function: Edit and query SQL task information, sql type selection query, select form or attachment to send mail to the specified recipient, as shown in the figure below.
+SQL task, used to connect to database and execute SQL.
 
-<p align="center">
-   <img src="/img/sql-node-en.png" width="80%" />
- </p>
+## create data source
+
+Refer to [Data Source](https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/guide/datasource/introduction.html)

Review comment:
       We should use a related path instead of the full path with a fixable version, in this case, we should use syntax `[Data Source](../datasource/introduction.md)`

##########
File path: docs/en-us/2.0.0/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,43 @@
 # SQL
 
-- Drag in the toolbar![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)Task node into the drawing board
-- Non-query SQL function: edit non-query SQL task information, select non-query for sql type, as shown in the figure below:
- <p align="center">
-  <img src="/img/sql-en.png" width="80%" />
-</p>
+## Overview
 
-- Query SQL function: Edit and query SQL task information, sql type selection query, select form or attachment to send mail to the specified recipient, as shown in the figure below.
+SQL task, used to connect to database and execute SQL.
 
-<p align="center">
-   <img src="/img/sql-node-en.png" width="80%" />
- </p>
+## create data source
+
+Refer to [Data Source](https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/guide/datasource/introduction.html)

Review comment:
       So as others change, others LGTM




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1037932831


   @zhongjiajie hi, I have submitted an update, and i'm sorry I accidentally removed assignment in https://github.com/apache/dolphinscheduler/issues/8020, could you reassin this issue to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#discussion_r800701713



##########
File path: docs/zh-cn/dev/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,41 @@
-# SQL节点
+# SQL
 
-- 拖动工具栏中的![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)任务节点到画板中
-- 非查询SQL功能：编辑非查询SQL任务信息，sql类型选择非查询，如下图所示：
-  <p align="center">
-   <img src="/img/sql-node.png" width="80%" />
- </p>
+## 综述
 
-- 查询SQL功能：编辑查询SQL任务信息，sql类型选择查询，选择表格或附件形式发送邮件到指定的收件人，如下图所示。
+SQL任务类型，用于连接远程数据库并执行相应SQL。
 
-<p align="center">
-   <img src="/img/sql-node2.png" width="80%" />
- </p>
+## 创建数据源
+
+- 点击数据源中心的“创建数据源”按钮，输入连接信息并测试连接。
+
+## 创建任务
+
+- 点击项目管理-项目名称-工作流定义，点击"创建工作流"按钮，进入DAG编辑页面。
+- 工具栏中拖动 <img src="/img/tasks/demo/sql-icon.png" width="25"/> 到画板中，选择需要连接的数据源，即可完成创建。

Review comment:
       we have a specific directory to keep all tasks icon
   ```suggestion
   - 工具栏中拖动 <img src="/img/tasks/icon/sql.png" width="25"/> 到画板中，选择需要连接的数据源，即可完成创建。
   ```

##########
File path: docs/zh-cn/dev/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,41 @@
-# SQL节点
+# SQL
 
-- 拖动工具栏中的![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)任务节点到画板中
-- 非查询SQL功能：编辑非查询SQL任务信息，sql类型选择非查询，如下图所示：
-  <p align="center">
-   <img src="/img/sql-node.png" width="80%" />
- </p>
+## 综述
 
-- 查询SQL功能：编辑查询SQL任务信息，sql类型选择查询，选择表格或附件形式发送邮件到指定的收件人，如下图所示。
+SQL任务类型，用于连接远程数据库并执行相应SQL。
 
-<p align="center">
-   <img src="/img/sql-node2.png" width="80%" />
- </p>
+## 创建数据源
+
+- 点击数据源中心的“创建数据源”按钮，输入连接信息并测试连接。
+
+## 创建任务
+
+- 点击项目管理-项目名称-工作流定义，点击"创建工作流"按钮，进入DAG编辑页面。
+- 工具栏中拖动 <img src="/img/tasks/demo/sql-icon.png" width="25"/> 到画板中，选择需要连接的数据源，即可完成创建。
+
+## 任务参数
 
 - 数据源：选择对应的数据源
 - sql类型：支持查询和非查询两种，查询是select类型的查询，是有结果集返回的，可以指定邮件通知为表格、附件或表格附件三种模板。非查询是没有结果集返回的，是针对update、delete、insert三种类型的操作。
 - sql参数：输入参数格式为key1=value1;key2=value2…
 - sql语句：SQL语句
-- UDF函数：对于HIVE类型的数据源，可以引用资源中心中创建的UDF函数,其他类型的数据源暂不支持UDF函数。
+- UDF函数：对于HIVE类型的数据源，可以引用资源中心中创建的UDF函数，其他类型的数据源暂不支持UDF函数。
 - 自定义参数：SQL任务类型，而存储过程是自定义参数顺序的给方法设置值自定义参数类型和数据类型同存储过程任务类型一样。区别在于SQL任务类型自定义参数会替换sql语句中${变量}。
 - 前置sql:前置sql在sql语句之前执行。
 - 后置sql:后置sql在sql语句之后执行。
+
+## 任务样例
+
+### 在hive中创建临时表并写入数据
+
+该样例向hive中创建临时表`tmp_hello_world`并写入一行数据。选择SQL类型为非查询，在创建临时表之前需要确保该表不存在，所以会用到SQL任务中“前置sql”的功能，在“sql语句”执行之前将该表删除。
+
+<img src="/img/tasks/demo/hive-sql-zh.png" alt="hive-sql-zh" style="zoom:80%;" />

Review comment:
       BTW, do you mind use whole screenshot with step number for how to create sql task? just like https://github.com/apache/dolphinscheduler-website/blob/7ec0cc27c2701b635a2296b141cc446a2da4e19d/img/tasks/demo/shell.jpg did?

##########
File path: docs/zh-cn/dev/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,41 @@
-# SQL节点
+# SQL
 
-- 拖动工具栏中的![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)任务节点到画板中
-- 非查询SQL功能：编辑非查询SQL任务信息，sql类型选择非查询，如下图所示：
-  <p align="center">
-   <img src="/img/sql-node.png" width="80%" />
- </p>
+## 综述
 
-- 查询SQL功能：编辑查询SQL任务信息，sql类型选择查询，选择表格或附件形式发送邮件到指定的收件人，如下图所示。
+SQL任务类型，用于连接远程数据库并执行相应SQL。
 
-<p align="center">
-   <img src="/img/sql-node2.png" width="80%" />
- </p>
+## 创建数据源
+
+- 点击数据源中心的“创建数据源”按钮，输入连接信息并测试连接。
+
+## 创建任务
+
+- 点击项目管理-项目名称-工作流定义，点击"创建工作流"按钮，进入DAG编辑页面。
+- 工具栏中拖动 <img src="/img/tasks/demo/sql-icon.png" width="25"/> 到画板中，选择需要连接的数据源，即可完成创建。
+
+## 任务参数
 
 - 数据源：选择对应的数据源
 - sql类型：支持查询和非查询两种，查询是select类型的查询，是有结果集返回的，可以指定邮件通知为表格、附件或表格附件三种模板。非查询是没有结果集返回的，是针对update、delete、insert三种类型的操作。
 - sql参数：输入参数格式为key1=value1;key2=value2…
 - sql语句：SQL语句
-- UDF函数：对于HIVE类型的数据源，可以引用资源中心中创建的UDF函数,其他类型的数据源暂不支持UDF函数。
+- UDF函数：对于HIVE类型的数据源，可以引用资源中心中创建的UDF函数，其他类型的数据源暂不支持UDF函数。
 - 自定义参数：SQL任务类型，而存储过程是自定义参数顺序的给方法设置值自定义参数类型和数据类型同存储过程任务类型一样。区别在于SQL任务类型自定义参数会替换sql语句中${变量}。
 - 前置sql:前置sql在sql语句之前执行。
 - 后置sql:后置sql在sql语句之后执行。
+
+## 任务样例
+
+### 在hive中创建临时表并写入数据
+
+该样例向hive中创建临时表`tmp_hello_world`并写入一行数据。选择SQL类型为非查询，在创建临时表之前需要确保该表不存在，所以会用到SQL任务中“前置sql”的功能，在“sql语句”执行之前将该表删除。
+
+<img src="/img/tasks/demo/hive-sql-zh.png" alt="hive-sql-zh" style="zoom:80%;" />
+
+运行该任务成功之后在hive中查询结果
+
+<img src="/img/tasks/demo/hive-result.png" alt="hive-result" style="zoom:80%;" />

Review comment:
       Please use markdown syntax

##########
File path: docs/en-us/dev/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,41 @@
 # SQL
 
-- Drag in the toolbar![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)Task node into the drawing board
-- Non-query SQL function: edit non-query SQL task information, select non-query for sql type, as shown in the figure below:
- <p align="center">
-  <img src="/img/sql-en.png" width="80%" />
-</p>
+## Overview
 
-- Query SQL function: Edit and query SQL task information, sql type selection query, select form or attachment to send mail to the specified recipient, as shown in the figure below.
+SQL task, used to connect to remote database and execute SQL.

Review comment:
       I think maybe we could remove keyword `remote`, just database because it could connect local DB, WDYT
   ```suggestion
   SQL task, used to connect to database and execute SQL.
   ```

##########
File path: docs/zh-cn/dev/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,41 @@
-# SQL节点
+# SQL
 
-- 拖动工具栏中的![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)任务节点到画板中
-- 非查询SQL功能：编辑非查询SQL任务信息，sql类型选择非查询，如下图所示：
-  <p align="center">
-   <img src="/img/sql-node.png" width="80%" />
- </p>
+## 综述
 
-- 查询SQL功能：编辑查询SQL任务信息，sql类型选择查询，选择表格或附件形式发送邮件到指定的收件人，如下图所示。
+SQL任务类型，用于连接远程数据库并执行相应SQL。
 
-<p align="center">
-   <img src="/img/sql-node2.png" width="80%" />
- </p>
+## 创建数据源
+
+- 点击数据源中心的“创建数据源”按钮，输入连接信息并测试连接。

Review comment:
       If there are just one point in the list, maybe we can just remove the list.
   BTW, could we use the hyperlink to how to add data sources?
   ```suggestion
   点击数据源中心的“创建数据源”按钮，输入连接信息并测试连接。
   ```

##########
File path: docs/zh-cn/dev/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,41 @@
-# SQL节点
+# SQL
 
-- 拖动工具栏中的![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)任务节点到画板中
-- 非查询SQL功能：编辑非查询SQL任务信息，sql类型选择非查询，如下图所示：
-  <p align="center">
-   <img src="/img/sql-node.png" width="80%" />
- </p>
+## 综述
 
-- 查询SQL功能：编辑查询SQL任务信息，sql类型选择查询，选择表格或附件形式发送邮件到指定的收件人，如下图所示。
+SQL任务类型，用于连接远程数据库并执行相应SQL。
 
-<p align="center">
-   <img src="/img/sql-node2.png" width="80%" />
- </p>
+## 创建数据源
+
+- 点击数据源中心的“创建数据源”按钮，输入连接信息并测试连接。
+
+## 创建任务
+
+- 点击项目管理-项目名称-工作流定义，点击"创建工作流"按钮，进入DAG编辑页面。
+- 工具栏中拖动 <img src="/img/tasks/demo/sql-icon.png" width="25"/> 到画板中，选择需要连接的数据源，即可完成创建。
+
+## 任务参数
 
 - 数据源：选择对应的数据源
 - sql类型：支持查询和非查询两种，查询是select类型的查询，是有结果集返回的，可以指定邮件通知为表格、附件或表格附件三种模板。非查询是没有结果集返回的，是针对update、delete、insert三种类型的操作。
 - sql参数：输入参数格式为key1=value1;key2=value2…
 - sql语句：SQL语句
-- UDF函数：对于HIVE类型的数据源，可以引用资源中心中创建的UDF函数,其他类型的数据源暂不支持UDF函数。
+- UDF函数：对于HIVE类型的数据源，可以引用资源中心中创建的UDF函数，其他类型的数据源暂不支持UDF函数。
 - 自定义参数：SQL任务类型，而存储过程是自定义参数顺序的给方法设置值自定义参数类型和数据类型同存储过程任务类型一样。区别在于SQL任务类型自定义参数会替换sql语句中${变量}。
 - 前置sql:前置sql在sql语句之前执行。
 - 后置sql:后置sql在sql语句之后执行。
+
+## 任务样例
+
+### 在hive中创建临时表并写入数据
+
+该样例向hive中创建临时表`tmp_hello_world`并写入一行数据。选择SQL类型为非查询，在创建临时表之前需要确保该表不存在，所以会用到SQL任务中“前置sql”的功能，在“sql语句”执行之前将该表删除。
+
+<img src="/img/tasks/demo/hive-sql-zh.png" alt="hive-sql-zh" style="zoom:80%;" />
+
+运行该任务成功之后在hive中查询结果

Review comment:
       Maybe we should add more detail about how to query the result. I think point out user go to hive cli or beeline to query results in good way, due to DolphinScheduler do not have ad-hoc mechanism, WDYT

##########
File path: docs/zh-cn/dev/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,41 @@
-# SQL节点
+# SQL
 
-- 拖动工具栏中的![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)任务节点到画板中
-- 非查询SQL功能：编辑非查询SQL任务信息，sql类型选择非查询，如下图所示：
-  <p align="center">
-   <img src="/img/sql-node.png" width="80%" />
- </p>
+## 综述
 
-- 查询SQL功能：编辑查询SQL任务信息，sql类型选择查询，选择表格或附件形式发送邮件到指定的收件人，如下图所示。
+SQL任务类型，用于连接远程数据库并执行相应SQL。
 
-<p align="center">
-   <img src="/img/sql-node2.png" width="80%" />
- </p>
+## 创建数据源
+
+- 点击数据源中心的“创建数据源”按钮，输入连接信息并测试连接。
+
+## 创建任务
+
+- 点击项目管理-项目名称-工作流定义，点击"创建工作流"按钮，进入DAG编辑页面。
+- 工具栏中拖动 <img src="/img/tasks/demo/sql-icon.png" width="25"/> 到画板中，选择需要连接的数据源，即可完成创建。
+
+## 任务参数
 
 - 数据源：选择对应的数据源
 - sql类型：支持查询和非查询两种，查询是select类型的查询，是有结果集返回的，可以指定邮件通知为表格、附件或表格附件三种模板。非查询是没有结果集返回的，是针对update、delete、insert三种类型的操作。
 - sql参数：输入参数格式为key1=value1;key2=value2…
 - sql语句：SQL语句
-- UDF函数：对于HIVE类型的数据源，可以引用资源中心中创建的UDF函数,其他类型的数据源暂不支持UDF函数。
+- UDF函数：对于HIVE类型的数据源，可以引用资源中心中创建的UDF函数，其他类型的数据源暂不支持UDF函数。
 - 自定义参数：SQL任务类型，而存储过程是自定义参数顺序的给方法设置值自定义参数类型和数据类型同存储过程任务类型一样。区别在于SQL任务类型自定义参数会替换sql语句中${变量}。
 - 前置sql:前置sql在sql语句之前执行。
 - 后置sql:后置sql在sql语句之后执行。
+
+## 任务样例
+
+### 在hive中创建临时表并写入数据
+
+该样例向hive中创建临时表`tmp_hello_world`并写入一行数据。选择SQL类型为非查询，在创建临时表之前需要确保该表不存在，所以会用到SQL任务中“前置sql”的功能，在“sql语句”执行之前将该表删除。
+
+<img src="/img/tasks/demo/hive-sql-zh.png" alt="hive-sql-zh" style="zoom:80%;" />

Review comment:
       Please use markdown syntax instead of html syntax. besides, we could only use English version pictures in both English and Chinese versions documents.
   ```suggestion
   ![hive-sql](/img/tasks/demo/hive-sql.png)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1031542076


   About the example of how to create tables, I thinks is better to make our example could run directly, could we use parameter in the table name, like `tmp_hello_world_${current_time}` to make sure table not exists


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1031561874


   > About the example of how to create tables, I thinks is better to make our example could run directly, could we use parameter in the table name, like `tmp_hello_world_${current_time}` to make sure table not exists
   
   I mean, just like below.
   ![image](https://user-images.githubusercontent.com/15820530/152813384-1a553cf1-a441-4964-9c52-251e7b84997b.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1038025310


   Thanks for the feedback, I restart the CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy edited a comment on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy edited a comment on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1038209375


   @zhongjiajie TBR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1038025310






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1031178253


   I am going to see tonight


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy edited a comment on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy edited a comment on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1038209375


   @zhongjiajie hi, TBR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1038209375


   @zhongjiajie PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1038052951


   Hi @hongshuboy I add some suggestion above, PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1038209964


   I accidentally removed assignment in https://github.com/apache/dolphinscheduler/issues/8020, could you reassin this issue to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] hongshuboy commented on pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
hongshuboy commented on pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#issuecomment-1028931368


   https://github.com/apache/dolphinscheduler/issues/8020


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #667: [Feature-8020][Document] Add example and notice about task type SQL

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #667:
URL: https://github.com/apache/dolphinscheduler-website/pull/667#discussion_r805323293



##########
File path: docs/en-us/2.0.0/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,43 @@
 # SQL
 
-- Drag in the toolbar![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)Task node into the drawing board
-- Non-query SQL function: edit non-query SQL task information, select non-query for sql type, as shown in the figure below:
- <p align="center">
-  <img src="/img/sql-en.png" width="80%" />
-</p>
+## Overview
 
-- Query SQL function: Edit and query SQL task information, sql type selection query, select form or attachment to send mail to the specified recipient, as shown in the figure below.
+SQL task, used to connect to database and execute SQL.
 
-<p align="center">
-   <img src="/img/sql-node-en.png" width="80%" />
- </p>
+## create data source
+
+Refer to [Data Source](https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/guide/datasource/introduction.html)

Review comment:
       We should use a related path instead of the full path with a fixable version, in this case, we should use syntax `[Data Source](../datasource/introduction.md)`

##########
File path: docs/en-us/2.0.0/user_doc/guide/task/sql.md
##########
@@ -1,22 +1,43 @@
 # SQL
 
-- Drag in the toolbar![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_SQL.png)Task node into the drawing board
-- Non-query SQL function: edit non-query SQL task information, select non-query for sql type, as shown in the figure below:
- <p align="center">
-  <img src="/img/sql-en.png" width="80%" />
-</p>
+## Overview
 
-- Query SQL function: Edit and query SQL task information, sql type selection query, select form or attachment to send mail to the specified recipient, as shown in the figure below.
+SQL task, used to connect to database and execute SQL.
 
-<p align="center">
-   <img src="/img/sql-node-en.png" width="80%" />
- </p>
+## create data source
+
+Refer to [Data Source](https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/guide/datasource/introduction.html)

Review comment:
       So as others change, others LGTM




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org