You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ankane (via GitHub)" <gi...@apache.org> on 2026/07/13 21:29:41 UTC

[PR] Include license and notice files in iceberg-storage-opendal crate [iceberg-rust]

ankane opened a new pull request, #2823:
URL: https://github.com/apache/iceberg-rust/pull/2823

   ## Which issue does this PR close?
   
   None
   
   ## What changes are included in this PR?
   
   Applies #1601 to the `iceberg-storage-opendal` crate.
   
   ## Are these changes tested?
   
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Include license and notice files in iceberg-storage-opendal crate [iceberg-rust]

Posted by "ankane (via GitHub)" <gi...@apache.org>.
ankane commented on PR #2823:
URL: https://github.com/apache/iceberg-rust/pull/2823#issuecomment-4972652739

   Thanks all!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Include license and notice files in iceberg-storage-opendal crate [iceberg-rust]

Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on PR #2823:
URL: https://github.com/apache/iceberg-rust/pull/2823#issuecomment-4971753792

   > Thanks for catching this! I'm merging this as it, and we should create a followup PR to add license and notice to other 2 crates and a CI to check this per Kevin's suggestion
   
   I can take those. I'll do the other 2 crates today, and later follow-up with the CI fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Include license and notice files in iceberg-storage-opendal crate [iceberg-rust]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2823:
URL: https://github.com/apache/iceberg-rust/pull/2823#issuecomment-4971543057

   thanks for catching this @ankane! Its really important that every crate we publish must contain both the license and notice files. 
   
   I've found 2 other crates with the same issue, 3 total:
   - iceberg-storage-opendal
   - iceberg-catalog-loader
   - iceberg-cache-moka
   
   I believe these are all newly added crates. It would be good to add a CI check so that we can enforce this invariant. 
   
   Maybe something like:
   ```
   - name: Check published crate legal files
     shell: bash
     run: |
       set -euo pipefail
   
       failed=0
   
       while IFS= read -r crate; do
         echo "Checking ${crate}..."
         files="$(cargo package \
           --package "${crate}" \
           --list \
           --locked)"
   
         for required in LICENSE NOTICE; do
           if ! grep -Fxq "${required}" <<<"${files}"; then
             echo "::error::${crate} package is missing top-level ${required}"
             failed=1
           fi
         done
       done < <(
         cargo metadata --no-deps --format-version 1 |
           jq -r '.packages[] | select(.publish != []) | .name'
       )
   
       exit "${failed}"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Include license and notice files in iceberg-storage-opendal crate [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY merged PR #2823:
URL: https://github.com/apache/iceberg-rust/pull/2823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org