You are viewing a plain text version of this content. The canonical link for it is here.

Posted to users@tomcat.apache.org by Mark Foley <mf...@novatec-inc.com> on 2023/11/10 16:49:45 UTC

FileUpload class not working with Tomcat 10.1

I recently upgraded from Tomcat 10.0.17 to 10.1.13.  When I previously upgraded
from 9.0.41 to 10.0.17 (back in 2/22) the FileUpload class broke. I fixed that
thanks to postings on stackoverflow, but now that I've
upgraded to 10.1.13 it is broken again! Here's the error I get:

An error occurred at line: [40] in the jsp file: [/schDistImportResults.jsp]
The method isMultipartContent(ServletRequestContext) is undefined for the type FileUpload

39: 
40: boolean isMultipart = FileUpload.isMultipartContent(new ServletRequestContext(request));
41: 
>
An error occurred at line: [133] in the jsp file: [/schDistImportResults.jsp]
ServletFileUpload cannot be resolved to a type

131: 
132: DiskFileItemFactory factory = new DiskFileItemFactory();   // Create a factory for disk-based file items
133: ServletFileUpload upload = new ServletFileUpload(factory); // Create a new file upload handler
134: List items = upload.parseRequest(new ServletRequestContext(request));                 // Parse the request
135: Iterator iter = items.iterator();                          // Process the uploaded items
136: FileItem item = null;

I've checked the RELEASE-NOTES, FAQ and searched the web.  I've checked the
UploadFile class (no clue) and looked for examples, but none resembled my app. 
I tried reverting back to the program version I had with 9.0.41, but that didn't
work. 

Here is all I changed in the program between Tomcat versions 9.0.41 and 10.0.17 (which worked):
Code:

26,28c26,28
< <%@ page import="org.apache.commons.fileupload.*,
<     org.apache.commons.fileupload.disk.*,
<     org.apache.commons.fileupload.servlet.*,
---
> <%@ page import="org.apache.tomcat.util.http.fileupload.*,
>     org.apache.tomcat.util.http.fileupload.disk.*,
>     org.apache.tomcat.util.http.fileupload.servlet.*,
40c40
< boolean isMultipart = FileUpload.isMultipartContent(request);
---
> boolean isMultipart = FileUpload.isMultipartContent(new ServletRequestContext(request));
134c134
< List items = upload.parseRequest(request);                 // Parse the request
---
> List items = upload.parseRequest(new ServletRequestContext(request));                 // Parse the request

I have quite a few programs that use the FileUpload methods. Does anyone know how to fix this latest breakage?

Thanks --Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org

Re: AW: FileUpload class not working with Tomcat 10.1

Posted by Christopher Schultz <ch...@christopherschultz.net>.

Mark,

On 4/23/24 13:42, Mark Foley wrote:
> I'm back with a related issue.
> 
> I was able to get the java class jakarta.servlet.annotation.MultipartConfig
> working back last November by adding the <servlet> definition shown in the
> included message below to my WEB-INF/web.xml file.
> 
> Now I need to add another program to the system that does file uploads. I
> created another <server> definition in WEB-INF/web.xml following the original:
> 
> <servlet>
>     <servlet-name>uploadfile</servlet-name>
>       <jsp-file>/1099R-Etrans.jsp</jsp-file>
>       <multipart-config>
>         <location>/tmp</location>
>         <max-file-size>20848820</max-file-size>
>         <max-request-size>418018841</max-request-size>
>         <file-size-threshold>1048576</file-size-threshold>
>       </multipart-config>
> </servlet>
> <servlet-mapping>
>     <servlet-name>uploadfile</servlet-name>
>     <url-pattern>/1099R-Etrans.jsp</url-pattern>
> </servlet-mapping>
> 
> That didn't work so well.  Now, any and all programs using the fileupload
> function launches this 2nd program 1099R-Etrans.jsp.  It appears that this
> second <servlet> definition replaces the first. Of course, I need to have the
> ability for more than one program in the system able to do file uploads.
> 
> How can I configure multiple JSP programs to all have file uploading enabled and
> launched by the correspoding requesting program?

Can you post both <servlet> definitions and the <servlet-mapping>s for 
each of them?

It's still yucky to use a JSP to do this IMHO.

-chris

> On Thu Nov 16 14:36:21 2023 Christopher Schultz <ch...@christopherschultz.net> wrote:
>> Mark,
>>
>> Apologies for not replying earlier; looks like you have made good
>> progress. See below.
>>
>> On 11/14/23 12:19, Mark Foley wrote:
>>> Anyway, enough griping! I have gotten it partially working thanks to your
>>> suggested link, and particulary you suggestion to put the servlet info in
>>> web.xml.  I've put the following in WEB-INF/web.xml:
>>>
>>> <servlet>
>>>     <servlet-name>uploadfile</servlet-name>
>>>       <jsp-file>/schDistImportResults.jsp</jsp-file>
>>>       <multipart-config>
>>>         <location>/tmp</location>
>>>         <max-file-size>20848820</max-file-size>
>>>         <max-request-size>418018841</max-request-size>
>>>         <file-size-threshold>1048576</file-size-threshold>
>>>       </multipart-config>
>>> </servlet>
>>> <servlet-mapping>
>>>     <servlet-name>uploadfile</servlet-name>
>>>     <url-pattern>/schDistImportResults.jsp</url-pattern>
>>> </servlet-mapping>
>>>
>>> I've only changed the <jsp-file> and <url-pattern> tags above. The others are
>>> as monkey-typed from your link example. I'll research the other parameters
>>> later.
>>>
>>> My jsp code is now:
>>>
>>> <%@ page import="javax.servlet.annotation.MultipartConfig.*" %>
>>
>> Nope, not for Tomcat 10. You need to use the jakarta package names.
>> Besides, you don't need the MultipartConfig in your code, anyway.
>>
>> You need /either/ an annotation (dicey in JSP code) /or/ an XML config,
>> so the XML should be sufficient. (But you should switch to a proper
>> servlet. DO IT! :)
>>
>>> if((contentType != null) && contentType.startsWith("multipart/form-data;"))
>>> {
>>>       InputStream inp = null;
>>>       DataInputStream ins = null;
>>>
>>>       Part fileUpload = request.getPart("taxResults");
>>>
>>>       if(fileUpload != null)
>>>       {
>>>           inp = fileUpload.getInputStream();
>>>           ins = new DataInputStream(inp);
>>>       }
>>>    
>>> while ((inp != null) && (ins.available() != 0))
>>> {
>>>       String  transaction = ins.readLine();
>>>       out.println("<br/>" + transaction);
>>> }
>>>
>>> ins.close();
>>> inp.close();
>>
>> I would use try-with-resources like this:
>>
>> try (InputStream in = , DataInputStream ins = ...) {
>> }
>>
>> Since you have no try/catch, your code can leak file handles and stuff
>> like that. Yuck. With try-with-resources, you don't even need the calls
>> to InputStream.close.
>>
>>> This actually worked!!!! I will experiment with it more and may be back with
>>> more questions (e.g. do I really need the web.xml? Could I not do:
>>> "inp = fileUpload.getInputStream(mypath);"). But ... maybe later.
>>>
>>> Vielen Dank!!! --Mark
>>
>> Na klar
>>
>> -chris
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: users-help@tomcat.apache.org
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: users-help@tomcat.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org

Re: FileUpload class not working with Tomcat 10.1

Posted by Christopher Schultz <ch...@christopherschultz.net>.

Mark and Chuck,

On 5/9/24 09:35, Chuck Caldarale wrote:
> You need the web.xml entries because you have extra configuration
> items (the <multipart-config> settings) that aren’t part of the
> default JSP servlet definition.
+1

If you didn't need to upload files to your JSP, you wouldn't have needed 
any of this in your web.xml file.

It's very weird to do this kind of logic in a JSP. I *highly* recommend 
that you split your JSP into at least two pieces:

1. A servlet that handles the upload, produces no output, and handles 
error conditions gracefully. It then forwards or redirects (as 
appropriate) to the page you want to display post-upload. You will need 
to map this servlet in web.xml, but it's less-stupid than mapping a JSP 
to a servlet-name and then mapping that same servlet-name back to a URL 
pattern which is the same as the JSP's path. I can see why you were 
saying "I have no idea why this is necessary": it seems useless but you 
must attach the file-upload metadata to something, and this is how you 
do it.

Note that you didn't have to do it that way. You could have done this:

<servlet>
   <servlet-name>uploadfile</servlet-name>
   <jsp-file>/schDistImports.jsp</jsp-file>
   ...
</servlet>
<servlet-mapping>
   <servlet-name>uploadfile</servlet-mapping>
   <url-pattern>/schDistImports</url-pattern> NOTE: no .jsp extension
</servlet-mapping>

In your case, the generic name "uploadfile" for a very specific type of 
upload (schDistImports) might be a mistake, since you might want to 
upload all kinds of files, such as 1099 forms or whatnot. One called 
"uploadfile" seems generic when it's not really generic: it's specific 
to that one workflow.

You can use any name you like. You can use any URL pattern you like as 
well, such as /sch/dist/imports. You don't have to be tied to your 
filesystem layout.

2. A page template (JSP is fine) that only generates page content. No 
mapping in web.xml is necessary for this, which is probably what you are 
used to.

-chris

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org