[GitHub] [incubator-nuttx-apps] v01d commented on a change in pull request #334: Don't copy headers outside of LittlevGL library

[GitBox <gi...@apache.org>]

v01d commented on a change in pull request #334:
URL: https://github.com/apache/incubator-nuttx-apps/pull/334#discussion_r455134281



##########
File path: graphics/lvgl/Makefile
##########
@@ -78,20 +78,21 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL)
 	$(Q) mv	lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME)
 	$(Q) touch $(LVGL_UNPACKNAME)
 
-lvgl/lvgl.h: $(LVGL_UNPACKNAME)
+$(LVGL_UNPACKNAME)/lvgl.h: $(LVGL_UNPACKNAME)
 
-$(APPDIR)/include/graphics/lvgl.h: lvgl/lvgl.h
-	@echo "CP: lvgl/lvgl.h"
-	$(Q) cp lvgl/lvgl.h $(APPDIR)/include/graphics/lvgl.h
+exports/graphics/lvgl.h: $(LVGL_UNPACKNAME)/lvgl.h
+	$(Q) mkdir -p exports/graphics
+	@echo "CP: $(LVGL_UNPACKNAME)/lvgl.h"
+	$(Q) cp $(LVGL_UNPACKNAME)/lvgl.h exports/graphics/lvgl.h

Review comment:
       Usually libraries assume some sort of layout for the include directory and the user only needs to account for installation prefix. In this case, lvgl is assuming a layout of <prefix>/lvgl/lvgl.h, so any extra component in the path should be part of the -I flag passed to the compiler. Adding extra prefixes could break existing programs following the expected inclusion format.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org