[jira] [Commented] (TEZ-3645) Reuse SerializationFactory while sorting, merging, and writing IFiles

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891373#comment-15891373 ] 

TezQA commented on TEZ-3645:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12855483/TEZ-3645.1.patch
  against master revision 6051542.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 5 new or modified test files.

      {color:red}-1 javac{color}.  The applied patch generated 50 javac compiler warnings (more than the master's current 37 warnings).

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2286//testReport/
Javac warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/2286//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2286//console

This message is automatically generated.

> Reuse SerializationFactory while sorting, merging, and writing IFiles 
> ----------------------------------------------------------------------
>
>                 Key: TEZ-3645
>                 URL: https://issues.apache.org/jira/browse/TEZ-3645
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: TEZ-3645.1.patch
>
>
> Of course this is not reusing the serializer, just the SerializationFactory and Serialization. They are jointly responsible for iterating over the list of available serializers and finding an acceptable one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)