You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/11/18 20:55:25 UTC
[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2089: SOLR-14999: Option to set the advertised port for Solr.
HoustonPutman opened a new pull request #2089:
URL: https://github.com/apache/lucene-solr/pull/2089
https://issues.apache.org/jira/browse/SOLR-14999
I am open to suggestions on the naming of this new option. Currently I have `-Dsolr.port.advertise` and `SOLR_PORT_ADVERTISE`, because I think those are more descriptive names than `hostPort`.
This is backwards compatible with the current `solr.xml`s, because the default value (`jetty.port`) is now checked in the Java code, rather than the xml.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman merged pull request #2089: SOLR-14999: Option to set the advertised port for Solr.
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #2089:
URL: https://github.com/apache/lucene-solr/pull/2089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #2089: SOLR-14999: Option to set the advertised port for Solr.
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #2089:
URL: https://github.com/apache/lucene-solr/pull/2089#discussion_r526487616
##########
File path: solr/solr-ref-guide/src/format-of-solr-xml.adoc
##########
@@ -134,9 +134,10 @@ The hostname Solr uses to access cores.
The url context path.
`hostPort`::
-The port Solr uses to access cores.
+The port Solr uses to access cores, and advertise Solr node locations through liveNodes.
+
-In the default `solr.xml` file, this is set to `${jetty.port:8983}`, which will use the Solr port defined in Jetty, and otherwise fall back to 8983.
+In the default `solr.xml` file, this is set to `${solr.port.advertise:0}`.
Review comment:
I'd like a sentence here giving an example why the user might care about it, i.e. solr running behind a proxy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman merged pull request #2089: SOLR-14999: Option to set the advertised port for Solr.
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #2089:
URL: https://github.com/apache/lucene-solr/pull/2089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org