You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by deathbearbrown <gi...@git.apache.org> on 2014/07/23 15:50:10 UTC

[GitHub] couchdb-fauxton pull request: Pulled views out into their own file...

GitHub user deathbearbrown opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/12

    Pulled views out into their own files

    The views.js file in the document addon was very big, old and getting unruley to work in.
    
    I broke out some of the views into their own files where it made sense:
    changesviews
    doceditorviews
    queryoptionsviews
    indexviews
    
    This is the first step in a larger refactor when we start cleaning up indexes. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/deathbearbrown/couchdb-fauxton breakout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit 81497990cdec0fbb3d867d3271e416447cbd5fd5
Author: deathbearbrown <de...@gmail.com>
Date:   2014-07-23T13:47:32Z

    Pulled views out into their own files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Pulled views out into their own file...

Posted by deathbearbrown <gi...@git.apache.org>.

Github user deathbearbrown commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/12#issuecomment-49876000
  
    And I removed "SearchBox" which I don't think we are using anywhere.  We use "JumpToDoc"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Pulled views out into their own file...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Pulled views out into their own file...

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/12#issuecomment-49876254
  
    +1 great idea to break them all up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---