You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Geoff Thorpe <ge...@geoffthorpe.net> on 2004/02/19 18:40:10 UTC
STATUS (was [PATCH] OpenSSL dynamic engines under 2.0.48)
On February 17, 2004 04:21 pm, Sander Temme wrote:
> I haven't reviewed the above, but isn't a bunch of logic for using
> hardware crypto devices already in HEAD? This is up for backport at
> line 151 of the httpd-2.0 STATUS.
I took a quick look and you are maybe thinking of something else. If its
the "ENGINE_init()" versus SSL_EXPERIMENTAL_ENGINE stuff you're referring
to, then that's more of an underlying autoconf-level issue.
However, I did notice something else - both the httpd-2.0 and httpd-2.1
STATUS files seem to have this comment;
* the shmcb code should just align its memory segment rather than
jumping through all the "safe" memcpy and memset hoops
Could this please be removed, as it makes no sense. Anyone who has read
and understood the internals would know why. There are certainly things
that could be done to improve the code however (and I really should find
time to do that), but the current comment is likely to lead someone to
doing something very painful to themselves.
Cheers,
Geoff
--
Geoff Thorpe
geoff@geoffthorpe.net
http://www.geoffthorpe.net/