[PR] BIGTOP-4554 Enable --docker-compose-plugin by default in docker-hadoo… [bigtop]

["takutotsuchie (via GitHub)" <gi...@apache.org>]

takutotsuchie opened a new pull request, #1413:
URL: https://github.com/apache/bigtop/pull/1413

   …p.sh
   
   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
   -->
   
   ### Description of PR
   
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
   - [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] BIGTOP-4554 Enable --docker-compose-plugin by default in docker-hadoo… [bigtop]

["iwasakims (via GitHub)" <gi...@apache.org>]

iwasakims commented on code in PR #1413:
URL: https://github.com/apache/bigtop/pull/1413#discussion_r4119858233


##########
provisioner/docker/docker-hadoop.sh:
##########
@@ -340,7 +340,7 @@ if [ $# -eq 0 ]; then
 fi
 
 yamlconf="config.yaml"
-DOCKER_COMPOSE_CMD="docker-compose"
+DOCKER_COMPOSE_CMD="docker compose"
 
 for arg in $@

Review Comment:
   We should remove the conditional and the change_docker_compose_cmd function too if we just change the default behavior and does not care `docker-compose` anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org