You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/05/01 03:25:01 UTC
[GitHub] srkukarni commented on a change in pull request #1700: adding sink
spec
srkukarni commented on a change in pull request #1700: adding sink spec
URL: https://github.com/apache/incubator-pulsar/pull/1700#discussion_r185160956
##########
File path: pulsar-functions/proto/src/main/proto/Function.proto
##########
@@ -64,6 +65,17 @@ message SourceSpec {
map<string,string> topicsToSerDeClassName = 4;
}
+message SinkSpec {
+ string className = 1;
+ // map in json format
+ string configs = 2;
+
+ // configs used only when source feeds into functions
+ SubscriptionType subscriptionType = 3;
Review comment:
this does not make sense for sink? Also please update the comments above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services