You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "khanimteyaz (GitHub)" <gi...@apache.org> on 2018/12/20 11:43:48 UTC
[GitHub] [incubator-dubbo] khanimteyaz opened issue #3026:
AccessLogFilter simple date formate reduce instance creation
AcceLogFilter message creation and last and current check was performing by each time simple date formate object creation. In this version of code I have use the ThreadLocal for each thread wise to create simple date format object instead of each call.
- [ ] I have searched the [issues](https://github.com/apache/incubator-dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/incubator-dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.0
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
1. xxx
2. xxx
3. xxx
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps?
### Actual Result
What actually happens?
AcceLogFilter message creation and last and current check was performing by each time simple date formate object creation. In this version of code I have use the ThreadLocal for each thread wise to create simple date format object instead of each call.
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3026 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed issue #3026:
AccessLogFilter simple date formate reduce instance creation
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ issue closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3026 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] khanimteyaz commented on issue #3026:
AccessLogFilter simple date formate reduce instance creation
Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
> Hi, I leave some comments, would u pls check it?
> :)
Thanks, I will.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3026 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #3026:
AccessLogFilter simple date formate reduce instance creation
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Hi, I leave some comments, would u pls check it?
:)
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3026 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org