[GitHub] [hudi] leesf commented on a diff in pull request #8437: [HUDI-6066] HoodieTableSource supports parquet predicate push down

["leesf (via GitHub)" <gi...@apache.org>]

leesf commented on code in PR #8437:
URL: https://github.com/apache/hudi/pull/8437#discussion_r1165586562


##########
hudi-flink-datasource/hudi-flink1.14.x/src/main/java/org/apache/hudi/table/format/cow/vector/reader/ParquetColumnarRowSplitReader.java:
##########
@@ -376,6 +383,26 @@ public void close() throws IOException {
     }
   }
 
+  private static UnboundRecordFilter getUnboundRecordFilterInstance(Configuration configuration) {

Review Comment:
   duplicate method can be simplified?



##########
hudi-flink-datasource/hudi-flink1.14.x/src/main/java/org/apache/hudi/table/format/cow/vector/reader/ParquetColumnarRowSplitReader.java:
##########
@@ -376,6 +383,26 @@ public void close() throws IOException {
     }
   }
 
+  private static UnboundRecordFilter getUnboundRecordFilterInstance(Configuration configuration) {

Review Comment:
   duplicate method and code can be simplified?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org