You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "ZhaoYang (JIRA)" <ji...@apache.org> on 2017/08/01 09:25:00 UTC
[jira] [Comment Edited] (CASSANDRA-13573)
ColumnMetadata.cellValueType() doesn't return correct type for non-frozen
collection
[ https://issues.apache.org/jira/browse/CASSANDRA-13573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079806#comment-16079806 ]
ZhaoYang edited comment on CASSANDRA-13573 at 8/1/17 9:24 AM:
--------------------------------------------------------------
first draft of the patch. if it looks good, I will prepare fixes for 2.2/3.0/3.11 as well
| [trunk|https://github.com/jasonstack/cassandra/commits/CASSANDRA-13573] | [unit|https://circleci.com/gh/jasonstack/cassandra/130] | [dtest|https://github.com/jasonstack/cassandra-dtest-riptano/commits/CASSANDRA-13573] |
unit test: passed.
dtest: {{cqlsh_tests.cqlsh_tests.TestCqlsh.test_describe}} & {{bootstrap_test.TestBootstrap.consistent_range_movement_false_with_rf1_should_succeed_test}} both are broken for some time
changes:
1. use {{type.toJSONString()}} with {{json.writeRawValue()}} instead of {{type.getString()}} to generate readable content
2. {{column.cellValueType}} now : {{a}}. if non-frozen collection, return value type, {{b}}. otherwise, return column type.
was (Author: jasonstack):
first draft of the patch. if it looks good, I will prepare fixes for 2.2/3.0/3.11 as well
| [trunk|https://github.com/jasonstack/cassandra/commits/CASSANDRA-13573] | [unit|https://circleci.com/gh/jasonstack/cassandra/130] | [dtest|https://github.com/jasonstack/cassandra-dtest/commits/CASSANDRA-13573] |
unit test: passed.
dtest: {{cqlsh_tests.cqlsh_tests.TestCqlsh.test_describe}} & {{bootstrap_test.TestBootstrap.consistent_range_movement_false_with_rf1_should_succeed_test}} both are broken for some time
changes:
1. use {{type.toJSONString()}} with {{json.writeRawValue()}} instead of {{type.getString()}} to generate readable content
2. {{column.cellValueType}} now : {{a}}. if non-frozen collection, return value type, {{b}}. otherwise, return column type.
> ColumnMetadata.cellValueType() doesn't return correct type for non-frozen collection
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-13573
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13573
> Project: Cassandra
> Issue Type: Bug
> Components: Core, CQL, Materialized Views, Tools
> Reporter: Stefano Ortolani
> Assignee: ZhaoYang
>
> Schema and data"
> {noformat}
> CREATE TABLE ks.cf (
> hash blob,
> report_id timeuuid,
> subject_ids frozen<set<int>>,
> PRIMARY KEY (hash, report_id)
> ) WITH CLUSTERING ORDER BY (report_id DESC);
> INSERT INTO ks.cf (hash, report_id, subject_ids) VALUES (0x1213, now(), {1,2,4,5});
> {noformat}
> sstabledump output is:
> {noformat}
> sstabledump mc-1-big-Data.db
> [
> {
> "partition" : {
> "key" : [ "1213" ],
> "position" : 0
> },
> "rows" : [
> {
> "type" : "row",
> "position" : 16,
> "clustering" : [ "ec01eed0-49d9-11e7-b39a-97a96f529c02" ],
> "liveness_info" : { "tstamp" : "2017-06-05T10:29:57.434856Z" },
> "cells" : [
> { "name" : "subject_ids", "value" : "" }
> ]
> }
> ]
> }
> ]
> {noformat}
> While the values are really there:
> {noformat}
> cqlsh:ks> select * from cf ;
> hash | report_id | subject_ids
> --------+--------------------------------------+-------------
> 0x1213 | 02bafff0-49d9-11e7-b39a-97a96f529c02 | {1, 2, 4}
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org