You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/24 03:26:35 UTC
[GitHub] [apisix-dashboard] gy09535 opened a new issue #1115: bug: host pass error with dashboard 2.0
gy09535 opened a new issue #1115:
URL: https://github.com/apache/apisix-dashboard/issues/1115
### Issue description
When we set upstream in dashboard ,the value of "upstream.pass_host" not be set, after that we set the nodes with domain, the domain value should be set to the backend node, but it not be set. because of the pass_host default value is pass( ref: https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L360 ), it can not execute the node host set logical(ref: https://github.com/apache/apisix/blob/master/apisix/init.lua#L306-L327 and https://github.com/apache/apisix/blob/master/apisix/init.lua#L467-L473). I have fixed it change the upstream default value to node, I think it is not a good idea, we should add the config in dashboard ui 2.0.
### Environment
* apisix version (cmd: `apisix version`):
* OS: (cmd: `uname -a`)
* OpenResty / Nginx version: (cmd: `nginx -V` or `openresty -V`)
### Minimal test code / Steps to reproduce the issue
1.
2.
3.
### What's the actual result? (including assertion message & call stack if applicable)
### What's the expected result?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gy09535 commented on issue #1115: bug: host pass error with dashboard 2.0
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #1115:
URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750727084
> Do you mean dashboard need to support config `pass_host`?
yeah, If we not do that, the upstream host should not be set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gy09535 edited a comment on issue #1115: bug: host pass error with dashboard 2.0
Posted by GitBox <gi...@apache.org>.
gy09535 edited a comment on issue #1115:
URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750727084
> Do you mean dashboard need to support config `pass_host`?
yeah, when we want change the backend service host, we can change it to node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1115: bug: host pass error with dashboard 2.0
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1115:
URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750742054
https://github.com/apache/apisix-dashboard/pull/1088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1115: bug: host pass error with dashboard 2.0
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1115:
URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750741730
already supported yesterday, please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1115: bug: host pass error with dashboard 2.0
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1115:
URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750723933
Do you mean dashboard need to support config `pass_host`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1115: bug: host pass error with dashboard 2.0
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1115:
URL: https://github.com/apache/apisix-dashboard/issues/1115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org