You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/13 15:34:03 UTC

[GitHub] [beam] cmachgodaddy commented on a change in pull request #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write

cmachgodaddy commented on a change in pull request #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write
URL: https://github.com/apache/beam/pull/9758#discussion_r392300502
 
 

 ##########
 File path: sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/sns/SnsCoderProviderRegistrar.java
 ##########
 @@ -32,6 +32,7 @@
   @Override
   public List<CoderProvider> getCoderProviders() {
     return ImmutableList.of(
-        CoderProviders.forCoder(TypeDescriptor.of(PublishResult.class), PublishResultCoder.of()));
+        CoderProviders.forCoder(
+            TypeDescriptor.of(PublishResult.class), PublishResultCoders.defaultPublishResult()));
 
 Review comment:
   Same here, any reasons this is not `XXXcoder.of(...)` pattern?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services