[GitHub] spark pull request #16888: [WIP] [SPARK-19552] [BUILD] Upgrade Netty version...

[jpinkul <gi...@git.apache.org>]

Github user jpinkul commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16888#discussion_r127502197
  
    --- Diff: common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java ---
    @@ -44,6 +44,27 @@
       private final long bodyLength;
       private long totalBytesTransferred;
     
    +  @Override
    +  public FileRegion touch() {
    +    return this;
    +  }
    +
    +  @Override
    +  public FileRegion touch(Object hint) {
    +    return this;
    +  }
    +
    +  @Override
    +  public FileRegion retain() {
    +    return this;
    --- End diff --
    
    I believe this breaks the netty reference counting logic, I think instead it should be
    ```
    return (TestFileRegion)super.retain();
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org