You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/04/18 07:29:18 UTC
Review Request: Moved checkpoint compatibility check from slave to master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10599/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c
src/slave/slave.cpp 00b2375505e362959ac34061e3066cf8ace96adf
Diff: https://reviews.apache.org/r/10599/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Moved checkpoint compatibility check from slave to
master.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10599/#review19422
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/10599/#comment40178>
Rephrase to checkpointing being disabled on the slave, rather than not supported, as this is clearer to the end-user / administrators.
- Ben Mahler
On April 18, 2013, 8:31 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10599/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 8:31 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c
> src/slave/slave.cpp 00b2375505e362959ac34061e3066cf8ace96adf
>
> Diff: https://reviews.apache.org/r/10599/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Moved checkpoint compatibility check from slave to
master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10599/
-----------------------------------------------------------
(Updated April 19, 2013, 1:28 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. no need for review.
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c
src/slave/slave.cpp 00b2375505e362959ac34061e3066cf8ace96adf
Diff: https://reviews.apache.org/r/10599/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Moved checkpoint compatibility check from slave to
master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10599/
-----------------------------------------------------------
(Updated April 18, 2013, 8:31 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased off trunk.
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c
src/slave/slave.cpp 00b2375505e362959ac34061e3066cf8ace96adf
Diff: https://reviews.apache.org/r/10599/diff/
Testing
-------
make check
Thanks,
Vinod Kone