[jira] [Commented] (MYFACES-4066) FlowBuilderFactoryBean Concurrency Issue

["Bill Lucy (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523924#comment-15523924 ] 

Bill Lucy commented on MYFACES-4066:
------------------------------------

I've attached a patch - synchronizing getFlowDefinitions - for review.  

> FlowBuilderFactoryBean Concurrency Issue
> ----------------------------------------
>
>                 Key: MYFACES-4066
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4066
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.2.11
>         Environment: WebSphere Liberty
>            Reporter: Bill Lucy
>            Assignee: Bill Lucy
>            Priority: Minor
>         Attachments: MYFACES-4066.patch
>
>
> I've come accross a concurrency issue in org.apache.myfaces.flow.cdi.FlowBuilderFactoryBean.getFlowDefinitions().  If multiple applications (with programmatic flows) are starting up simultaneously, it's possible that the two responsible threads can concurrently modify the shared object FlowBuilderFactoryBean.flowDefinitions.  That can result in the flowDefinitions for one of the applications not being processed.  
> Synchronizing the getFlowDefinitions() method is the simplest fix for this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)