You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/07/17 10:24:53 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #24715: chore: update deprecated arguments in schema
sebastianliebscher opened a new pull request, #24715:
URL: https://github.com/apache/superset/pull/24715
### SUMMARY
[Since marshmallow 3.10](https://marshmallow.readthedocs.io/en/latest/changelog.html#id15) passing field metadata via keyword arguments is deprecated.
To search and replace I used the following regex:
- `description=(.*)\)`
- `metadata={"description": "$1"})
`
### TESTING INSTRUCTIONS
`pytest` or `./scripts/tests/run.sh
`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24715: chore: update deprecated arguments in schema
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24715:
URL: https://github.com/apache/superset/pull/24715#issuecomment-1637834380
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24715?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24715](https://app.codecov.io/gh/apache/superset/pull/24715?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (32bc716) into [master](https://app.codecov.io/gh/apache/superset/commit/0328dd270467e71260bfa85078beb7b38a87877b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0328dd2) will **decrease** coverage by `10.81%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 32bc716 differs from pull request most recent head 2407895. Consider uploading reports for the commit 2407895 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24715 +/- ##
===========================================
- Coverage 68.97% 58.17% -10.81%
===========================================
Files 1901 1901
Lines 74008 74008
Branches 8183 8183
===========================================
- Hits 51047 43051 -7996
- Misses 20840 28836 +7996
Partials 2121 2121
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `54.01% <100.00%> (ø)` | |
| python | `60.85% <100.00%> (-22.61%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.83% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/row\_level\_security/schemas.py](https://app.codecov.io/gh/apache/superset/pull/24715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvcm93X2xldmVsX3NlY3VyaXR5L3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
... and [293 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24715/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #24715: chore: update deprecated arguments in schema
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #24715:
URL: https://github.com/apache/superset/pull/24715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org