You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/14 15:13:22 UTC

[GitHub] [flink] slinkydeveloper opened a new pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

slinkydeveloper opened a new pull request #18370:
URL: https://github.com/apache/flink/pull/18370


   ## What is the purpose of the change
   
   This PR allows to store anonymous, but still uniquely identified, names in `ObjectIdentifier`. The reason for this is to simplify th implementation of https://github.com/apache/flink/pull/183491, in particular, thanks to this change we don't need to modify the assumptions both inside the planner and for connectors that `ObjectIdentifier` can be null, allowing us to remove this change: https://github.com/apache/flink/pull/18349/commits/9427c7f0b57216f26520d55a7f1817ac2b2676c9
   
   ## Brief change log
   
   * Add `ObjectIdentifier#ofAnonymous`
   
   ## Verifying this change
   
   This change added a unit test.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: yes
     - The runtime per-record code paths (performance sensitive): yes
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: yes
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * c94bcef6bc47aef3ef09176b57c950cc064be725 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper commented on a change in pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18370:
URL: https://github.com/apache/flink/pull/18370#discussion_r785006615



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";
 
+    @Nullable private final String catalogName;
+    @Nullable private final String databaseName;
     private final String objectName;
 
     public static ObjectIdentifier of(String catalogName, String databaseName, String objectName) {
-        return new ObjectIdentifier(catalogName, databaseName, objectName);
+        if (Objects.equals(catalogName, UNKNOWN) || Objects.equals(databaseName, UNKNOWN)) {
+            throw new IllegalArgumentException(
+                    String.format("Catalog or database cannot be named '%s'", UNKNOWN));
+        }
+        return new ObjectIdentifier(
+                Preconditions.checkNotNull(catalogName, "Catalog name must not be null."),
+                Preconditions.checkNotNull(databaseName, "Database name must not be null."),
+                Preconditions.checkNotNull(objectName, "Object name must not be null."));
+    }
+
+    static ObjectIdentifier ofAnonymous(String objectName) {
+        return new ObjectIdentifier(
+                null,
+                null,
+                Preconditions.checkNotNull(objectName, "Object name must not be null."));
     }
 
     private ObjectIdentifier(String catalogName, String databaseName, String objectName) {
-        this.catalogName =
-                Preconditions.checkNotNull(catalogName, "Catalog name must not be null.");
-        this.databaseName =
-                Preconditions.checkNotNull(databaseName, "Database name must not be null.");
-        this.objectName = Preconditions.checkNotNull(objectName, "Object name must not be null.");
+        this.catalogName = catalogName;
+        this.databaseName = databaseName;
+        this.objectName = objectName;
     }
 
     public String getCatalogName() {
+        if (catalogName == null) {
+            return UNKNOWN;
+        }
         return catalogName;
     }
 
     public String getDatabaseName() {
+        if (catalogName == null) {
+            return UNKNOWN;
+        }
         return databaseName;
     }
 
     public String getObjectName() {
         return objectName;
     }
 
-    public ObjectPath toObjectPath() {
+    /**
+     * Convert this {@link ObjectIdentifier} to {@link ObjectPath}.
+     *
+     * @throws IllegalStateException if the identifier cannot be converted
+     */
+    public ObjectPath toObjectPath() throws IllegalStateException {
+        if (catalogName == null) {
+            throw new IllegalStateException(
+                    "This ObjectIdentifier instance refers to an anonymous object, "
+                            + "hence it cannot be converted to ObjectPath and cannot be serialized.");
+        }
         return new ObjectPath(databaseName, objectName);
     }
 
     /** List of the component names of this object identifier. */
     public List<String> toList() {
+        if (catalogName == null) {

Review comment:
       I think we should keep the 1 argument, as it doesn't break `UnresolvedIdentifier#of` and can be used safely by calcite




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * c94bcef6bc47aef3ef09176b57c950cc064be725 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper commented on a change in pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18370:
URL: https://github.com/apache/flink/pull/18370#discussion_r785007423



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";
 
+    @Nullable private final String catalogName;
+    @Nullable private final String databaseName;
     private final String objectName;
 
     public static ObjectIdentifier of(String catalogName, String databaseName, String objectName) {
-        return new ObjectIdentifier(catalogName, databaseName, objectName);
+        if (Objects.equals(catalogName, UNKNOWN) || Objects.equals(databaseName, UNKNOWN)) {
+            throw new IllegalArgumentException(

Review comment:
       Also, returning anonymous in if the user passes `<UNKNOWN>` for catalog and database name case means exposing the `ofAnonymous` functionality




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bdf67003a77f231fd4611cfb1e694764db6e59c2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bdf67003a77f231fd4611cfb1e694764db6e59c2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * bdf67003a77f231fd4611cfb1e694764db6e59c2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper commented on a change in pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18370:
URL: https://github.com/apache/flink/pull/18370#discussion_r784944167



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";

Review comment:
       It's used in the tests, and i think package private doesn't hurt




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr closed pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18370:
URL: https://github.com/apache/flink/pull/18370


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * c94bcef6bc47aef3ef09176b57c950cc064be725 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2946895204999eb86d315c494c816a42c79ba4ba",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2946895204999eb86d315c494c816a42c79ba4ba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c94bcef6bc47aef3ef09176b57c950cc064be725 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475) 
   * 2946895204999eb86d315c494c816a42c79ba4ba UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * c94bcef6bc47aef3ef09176b57c950cc064be725 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * c94bcef6bc47aef3ef09176b57c950cc064be725 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * c94bcef6bc47aef3ef09176b57c950cc064be725 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c94bcef6bc47aef3ef09176b57c950cc064be725 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * c94bcef6bc47aef3ef09176b57c950cc064be725 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * c94bcef6bc47aef3ef09176b57c950cc064be725 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bdf67003a77f231fd4611cfb1e694764db6e59c2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bdf67003a77f231fd4611cfb1e694764db6e59c2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   * bdf67003a77f231fd4611cfb1e694764db6e59c2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr commented on a change in pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18370:
URL: https://github.com/apache/flink/pull/18370#discussion_r784928206



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";
 
+    @Nullable private final String catalogName;
+    @Nullable private final String databaseName;

Review comment:
       nit: `@Nullable String` next to the data type

##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";

Review comment:
       `private`?

##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";
 
+    @Nullable private final String catalogName;
+    @Nullable private final String databaseName;
     private final String objectName;
 
     public static ObjectIdentifier of(String catalogName, String databaseName, String objectName) {
-        return new ObjectIdentifier(catalogName, databaseName, objectName);
+        if (Objects.equals(catalogName, UNKNOWN) || Objects.equals(databaseName, UNKNOWN)) {
+            throw new IllegalArgumentException(

Review comment:
       let's return `ofAnonymous()` instead. otherwise a copy operation `ObjectIdentifier.of(other.getCatalogTable(), other.getDatabaseName(), other.getObjectName().toUpper())` could fail.

##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";
 
+    @Nullable private final String catalogName;
+    @Nullable private final String databaseName;
     private final String objectName;
 
     public static ObjectIdentifier of(String catalogName, String databaseName, String objectName) {
-        return new ObjectIdentifier(catalogName, databaseName, objectName);
+        if (Objects.equals(catalogName, UNKNOWN) || Objects.equals(databaseName, UNKNOWN)) {
+            throw new IllegalArgumentException(
+                    String.format("Catalog or database cannot be named '%s'", UNKNOWN));
+        }
+        return new ObjectIdentifier(
+                Preconditions.checkNotNull(catalogName, "Catalog name must not be null."),
+                Preconditions.checkNotNull(databaseName, "Database name must not be null."),
+                Preconditions.checkNotNull(objectName, "Object name must not be null."));
+    }
+
+    static ObjectIdentifier ofAnonymous(String objectName) {
+        return new ObjectIdentifier(
+                null,
+                null,
+                Preconditions.checkNotNull(objectName, "Object name must not be null."));
     }
 
     private ObjectIdentifier(String catalogName, String databaseName, String objectName) {
-        this.catalogName =
-                Preconditions.checkNotNull(catalogName, "Catalog name must not be null.");
-        this.databaseName =
-                Preconditions.checkNotNull(databaseName, "Database name must not be null.");
-        this.objectName = Preconditions.checkNotNull(objectName, "Object name must not be null.");
+        this.catalogName = catalogName;
+        this.databaseName = databaseName;
+        this.objectName = objectName;
     }
 
     public String getCatalogName() {
+        if (catalogName == null) {
+            return UNKNOWN;
+        }
         return catalogName;
     }
 
     public String getDatabaseName() {
+        if (catalogName == null) {
+            return UNKNOWN;
+        }
         return databaseName;
     }
 
     public String getObjectName() {
         return objectName;
     }
 
-    public ObjectPath toObjectPath() {
+    /**
+     * Convert this {@link ObjectIdentifier} to {@link ObjectPath}.
+     *
+     * @throws IllegalStateException if the identifier cannot be converted
+     */
+    public ObjectPath toObjectPath() throws IllegalStateException {
+        if (catalogName == null) {
+            throw new IllegalStateException(
+                    "This ObjectIdentifier instance refers to an anonymous object, "
+                            + "hence it cannot be converted to ObjectPath and cannot be serialized.");
+        }
         return new ObjectPath(databaseName, objectName);
     }
 
     /** List of the component names of this object identifier. */
     public List<String> toList() {
+        if (catalogName == null) {
+            return Collections.singletonList(getObjectName());
+        }
         return Arrays.asList(getCatalogName(), getDatabaseName(), getObjectName());
     }
 
     /**
      * Returns a string that fully serializes this instance. The serialized string can be used for
      * transmitting or persisting an object identifier.
+     *
+     * @throws IllegalStateException if the identifier cannot be serialized
      */
-    public String asSerializableString() {
+    public String asSerializableString() throws IllegalStateException {
+        if (catalogName == null) {
+            throw new IllegalStateException(

Review comment:
       `TableException`

##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";
 
+    @Nullable private final String catalogName;
+    @Nullable private final String databaseName;
     private final String objectName;
 
     public static ObjectIdentifier of(String catalogName, String databaseName, String objectName) {
-        return new ObjectIdentifier(catalogName, databaseName, objectName);
+        if (Objects.equals(catalogName, UNKNOWN) || Objects.equals(databaseName, UNKNOWN)) {
+            throw new IllegalArgumentException(
+                    String.format("Catalog or database cannot be named '%s'", UNKNOWN));
+        }
+        return new ObjectIdentifier(
+                Preconditions.checkNotNull(catalogName, "Catalog name must not be null."),
+                Preconditions.checkNotNull(databaseName, "Database name must not be null."),
+                Preconditions.checkNotNull(objectName, "Object name must not be null."));
+    }
+
+    static ObjectIdentifier ofAnonymous(String objectName) {
+        return new ObjectIdentifier(
+                null,
+                null,
+                Preconditions.checkNotNull(objectName, "Object name must not be null."));
     }
 
     private ObjectIdentifier(String catalogName, String databaseName, String objectName) {
-        this.catalogName =
-                Preconditions.checkNotNull(catalogName, "Catalog name must not be null.");
-        this.databaseName =
-                Preconditions.checkNotNull(databaseName, "Database name must not be null.");
-        this.objectName = Preconditions.checkNotNull(objectName, "Object name must not be null.");
+        this.catalogName = catalogName;
+        this.databaseName = databaseName;
+        this.objectName = objectName;
     }
 
     public String getCatalogName() {
+        if (catalogName == null) {
+            return UNKNOWN;
+        }
         return catalogName;
     }
 
     public String getDatabaseName() {
+        if (catalogName == null) {
+            return UNKNOWN;
+        }
         return databaseName;
     }
 
     public String getObjectName() {
         return objectName;
     }
 
-    public ObjectPath toObjectPath() {
+    /**
+     * Convert this {@link ObjectIdentifier} to {@link ObjectPath}.
+     *
+     * @throws IllegalStateException if the identifier cannot be converted
+     */
+    public ObjectPath toObjectPath() throws IllegalStateException {
+        if (catalogName == null) {
+            throw new IllegalStateException(

Review comment:
       `TableException`

##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";
 
+    @Nullable private final String catalogName;
+    @Nullable private final String databaseName;
     private final String objectName;
 
     public static ObjectIdentifier of(String catalogName, String databaseName, String objectName) {
-        return new ObjectIdentifier(catalogName, databaseName, objectName);
+        if (Objects.equals(catalogName, UNKNOWN) || Objects.equals(databaseName, UNKNOWN)) {
+            throw new IllegalArgumentException(
+                    String.format("Catalog or database cannot be named '%s'", UNKNOWN));
+        }
+        return new ObjectIdentifier(
+                Preconditions.checkNotNull(catalogName, "Catalog name must not be null."),
+                Preconditions.checkNotNull(databaseName, "Database name must not be null."),
+                Preconditions.checkNotNull(objectName, "Object name must not be null."));
+    }
+
+    static ObjectIdentifier ofAnonymous(String objectName) {
+        return new ObjectIdentifier(
+                null,
+                null,
+                Preconditions.checkNotNull(objectName, "Object name must not be null."));
     }
 
     private ObjectIdentifier(String catalogName, String databaseName, String objectName) {
-        this.catalogName =
-                Preconditions.checkNotNull(catalogName, "Catalog name must not be null.");
-        this.databaseName =
-                Preconditions.checkNotNull(databaseName, "Database name must not be null.");
-        this.objectName = Preconditions.checkNotNull(objectName, "Object name must not be null.");
+        this.catalogName = catalogName;
+        this.databaseName = databaseName;
+        this.objectName = objectName;
     }
 
     public String getCatalogName() {
+        if (catalogName == null) {
+            return UNKNOWN;
+        }
         return catalogName;
     }
 
     public String getDatabaseName() {
+        if (catalogName == null) {
+            return UNKNOWN;
+        }
         return databaseName;
     }
 
     public String getObjectName() {
         return objectName;
     }
 
-    public ObjectPath toObjectPath() {
+    /**
+     * Convert this {@link ObjectIdentifier} to {@link ObjectPath}.
+     *
+     * @throws IllegalStateException if the identifier cannot be converted
+     */
+    public ObjectPath toObjectPath() throws IllegalStateException {
+        if (catalogName == null) {
+            throw new IllegalStateException(
+                    "This ObjectIdentifier instance refers to an anonymous object, "
+                            + "hence it cannot be converted to ObjectPath and cannot be serialized.");
+        }
         return new ObjectPath(databaseName, objectName);
     }
 
     /** List of the component names of this object identifier. */
     public List<String> toList() {
+        if (catalogName == null) {

Review comment:
       I revert my previous comment. I think it is safer to not have this check here.
   e.g. we use it for `org.apache.flink.table.catalog.UnresolvedIdentifier#of(org.apache.flink.table.catalog.ObjectIdentifier)`

##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";
 
+    @Nullable private final String catalogName;
+    @Nullable private final String databaseName;
     private final String objectName;
 
     public static ObjectIdentifier of(String catalogName, String databaseName, String objectName) {
-        return new ObjectIdentifier(catalogName, databaseName, objectName);
+        if (Objects.equals(catalogName, UNKNOWN) || Objects.equals(databaseName, UNKNOWN)) {
+            throw new IllegalArgumentException(
+                    String.format("Catalog or database cannot be named '%s'", UNKNOWN));
+        }
+        return new ObjectIdentifier(
+                Preconditions.checkNotNull(catalogName, "Catalog name must not be null."),
+                Preconditions.checkNotNull(databaseName, "Database name must not be null."),
+                Preconditions.checkNotNull(objectName, "Object name must not be null."));
+    }
+
+    static ObjectIdentifier ofAnonymous(String objectName) {

Review comment:
       explain the reason for this method and why it should not be exposed in the future




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013216628


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 71ecc074aaf07cb5b8b887dafeea29d030573c89 (Fri Jan 14 15:18:50 UTC 2022)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475",
       "triggerID" : "c94bcef6bc47aef3ef09176b57c950cc064be725",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2946895204999eb86d315c494c816a42c79ba4ba",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29527",
       "triggerID" : "2946895204999eb86d315c494c816a42c79ba4ba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c94bcef6bc47aef3ef09176b57c950cc064be725 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29475) 
   * 2946895204999eb86d315c494c816a42c79ba4ba Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29527) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper commented on a change in pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18370:
URL: https://github.com/apache/flink/pull/18370#discussion_r784946101



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java
##########
@@ -42,50 +45,88 @@
 @PublicEvolving
 public final class ObjectIdentifier implements Serializable {
 
-    private final String catalogName;
-
-    private final String databaseName;
+    static final String UNKNOWN = "<UNKNOWN>";
 
+    @Nullable private final String catalogName;
+    @Nullable private final String databaseName;
     private final String objectName;
 
     public static ObjectIdentifier of(String catalogName, String databaseName, String objectName) {
-        return new ObjectIdentifier(catalogName, databaseName, objectName);
+        if (Objects.equals(catalogName, UNKNOWN) || Objects.equals(databaseName, UNKNOWN)) {
+            throw new IllegalArgumentException(

Review comment:
       Can you show an example where one should copy an anonymous identifier?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18370: [hotfix][table-common] Introduce ObjectIdentifier.ofAnonymous to allow storing anonymous, but still uniquely identified, names in ObjectIdentifier

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18370:
URL: https://github.com/apache/flink/pull/18370#issuecomment-1013215185


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456",
       "triggerID" : "71ecc074aaf07cb5b8b887dafeea29d030573c89",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466",
       "triggerID" : "ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71ecc074aaf07cb5b8b887dafeea29d030573c89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29456) 
   * ec54d2040c5fabf8ba0931b4e314aff8a7b3e0bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29466) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org