You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2017/04/22 05:42:10 UTC
svn commit: r1792263 -
/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java
Author: tilman
Date: Sat Apr 22 05:42:10 2017
New Revision: 1792263
URL: http://svn.apache.org/viewvc?rev=1792263&view=rev
Log:
PDFBOX-2852: clarify method parameters
Modified:
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java?rev=1792263&r1=1792262&r2=1792263&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMapParser.java Sat Apr 22 05:42:10 2017
@@ -105,22 +105,22 @@ public class CMapParser
switch (op.op)
{
case "usecmap":
- parseUsecmap(previousToken, result);
+ parseUsecmap((LiteralName) previousToken, result);
break;
case "begincodespacerange":
- parseBegincodespacerange(previousToken, cmapStream, result);
+ parseBegincodespacerange((Number) previousToken, cmapStream, result);
break;
case "beginbfchar":
- parseBeginbfchar(previousToken, cmapStream, result);
+ parseBeginbfchar((Number) previousToken, cmapStream, result);
break;
case "beginbfrange":
- parseBeginbfrange(previousToken, cmapStream, result);
+ parseBeginbfrange((Number) previousToken, cmapStream, result);
break;
case "begincidchar":
- parseBegincidchar(previousToken, cmapStream, result);
+ parseBegincidchar((Number) previousToken, cmapStream, result);
break;
case "begincidrange":
- parseBegincidrange(previousToken, cmapStream, result);
+ parseBegincidrange((Integer) previousToken, cmapStream, result);
break;
default:
break;
@@ -128,24 +128,22 @@ public class CMapParser
}
else if (token instanceof LiteralName)
{
- parseLiteralName(token, cmapStream, result);
+ parseLiteralName((LiteralName) token, cmapStream, result);
}
previousToken = token;
}
return result;
}
- private void parseUsecmap(Object previousToken, CMap result) throws IOException
+ private void parseUsecmap(LiteralName useCmapName, CMap result) throws IOException
{
- LiteralName useCmapName = (LiteralName) previousToken;
InputStream useStream = getExternalCMap(useCmapName.name);
CMap useCMap = parse(useStream);
result.useCmap(useCMap);
}
- private void parseLiteralName(Object token, PushbackInputStream cmapStream, CMap result) throws IOException
+ private void parseLiteralName(LiteralName literal, PushbackInputStream cmapStream, CMap result) throws IOException
{
- LiteralName literal = (LiteralName) token;
switch (literal.name)
{
case "WMode":
@@ -220,9 +218,8 @@ public class CMapParser
}
}
- private void parseBegincodespacerange(Object previousToken, PushbackInputStream cmapStream, CMap result) throws IOException
+ private void parseBegincodespacerange(Number cosCount, PushbackInputStream cmapStream, CMap result) throws IOException
{
- Number cosCount = (Number) previousToken;
for (int j = 0; j < cosCount.intValue(); j++)
{
Object nextToken = parseNextToken(cmapStream);
@@ -244,9 +241,8 @@ public class CMapParser
}
}
- private void parseBeginbfchar(Object previousToken, PushbackInputStream cmapStream, CMap result) throws IOException
+ private void parseBeginbfchar(Number cosCount, PushbackInputStream cmapStream, CMap result) throws IOException
{
- Number cosCount = (Number) previousToken;
for (int j = 0; j < cosCount.intValue(); j++)
{
Object nextToken = parseNextToken(cmapStream);
@@ -279,9 +275,8 @@ public class CMapParser
}
}
- private void parseBegincidrange(Object previousToken, PushbackInputStream cmapStream, CMap result) throws IOException
+ private void parseBegincidrange(int numberOfLines, PushbackInputStream cmapStream, CMap result) throws IOException
{
- int numberOfLines = (Integer) previousToken;
for (int n = 0; n < numberOfLines; n++)
{
Object nextToken = parseNextToken(cmapStream);
@@ -317,9 +312,8 @@ public class CMapParser
}
}
- private void parseBegincidchar(Object previousToken, PushbackInputStream cmapStream, CMap result) throws IOException
+ private void parseBegincidchar(Number cosCount, PushbackInputStream cmapStream, CMap result) throws IOException
{
- Number cosCount = (Number) previousToken;
for (int j = 0; j < cosCount.intValue(); j++)
{
Object nextToken = parseNextToken(cmapStream);
@@ -339,10 +333,8 @@ public class CMapParser
}
}
- private void parseBeginbfrange(Object previousToken, PushbackInputStream cmapStream, CMap result) throws IOException
+ private void parseBeginbfrange(Number cosCount, PushbackInputStream cmapStream, CMap result) throws IOException
{
- Number cosCount = (Number) previousToken;
-
for (int j = 0; j < cosCount.intValue(); j++)
{
Object nextToken = parseNextToken(cmapStream);