[jira] [Commented] (SAMZA-801) MetricsSnapshotReporter cannot tolerate errors

["Roger Hoover (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975734#comment-14975734 ] 

Roger Hoover commented on SAMZA-801:
------------------------------------

https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ScheduledExecutorService.html#scheduleWithFixedDelay-java.lang.Runnable-long-long-java.util.concurrent.TimeUnit-

"If any execution of the task encounters an exception, subsequent executions are suppressed"

> MetricsSnapshotReporter cannot tolerate errors 
> -----------------------------------------------
>
>                 Key: SAMZA-801
>                 URL: https://issues.apache.org/jira/browse/SAMZA-801
>             Project: Samza
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.9.1
>            Reporter: Roger Hoover
>
> If an error occurs in MetricsSnapshotReporter.run(), it does not get logged anywhere and Executor.scheduleWithFixedDelay() will not reschedule it.  The effect is that metrics stop being sent to the metrics topic.
> There should be a try/catch in MetricsSnapshotReporter.run() which logs errors and suppresses them to that the thread still had a chance to run again.
> I ran into this by creating a custom metric (https://github.com/Quantiply/rico/blob/master/core/src/main/java/com/quantiply/samza/metrics/WindowedMapGauge.java) that was accidentally unserializable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)