[GitHub] [beam] tvalentyn edited a comment on pull request #16715: [BEAM-13709] Parse options with prefix --no_ through PipelineOptions(**params) with custom checks

[GitBox <gi...@apache.org>]

tvalentyn edited a comment on pull request #16715:
URL: https://github.com/apache/beam/pull/16715#issuecomment-1030567382


   I think the consitency we can pursue here is: when we initialize options that have store_true / store_false actions, we don't allow values, but we intepret the fact that the option is specified. In apis that expect K-V pairs (PipelineOpitions(), from_dictionary(), we need to pass some value, so we only allow `True` as value and interpret  it as: 'option is present', not necessarily that the corresponding dest needs to be set to `True`. This is what argparse does, so this would be consistent with the command-line behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org