You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/09/07 07:43:01 UTC

[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on a diff in pull request #36: SLING-11567 add null checks

joerghoh commented on code in PR #36:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/36#discussion_r964496153


##########
src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java:
##########
@@ -90,6 +90,10 @@ protected String checkKey(final String key) {
     @SuppressWarnings("unchecked")
     public <T> T get(final @NotNull String aKey, final @NotNull Class<T> type) {

Review Comment:
   I decided the remove the ```@NotNull``` annotations instead, because they are misleading (and actually wrong). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org