You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/09 19:16:20 UTC

[GitHub] [beam] egalpin commented on a change in pull request #14933: [BEAM-12421] Migrates ElasticsearchIOTest to use testContainers

egalpin commented on a change in pull request #14933:
URL: https://github.com/apache/beam/pull/14933#discussion_r648606002



##########
File path: sdks/java/io/elasticsearch-tests/elasticsearch-tests-7/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTest.java
##########
@@ -46,63 +45,39 @@
 
 /** Tests for {@link ElasticsearchIO} version 7. */
 @ThreadLeakScope(ThreadLeakScope.Scope.NONE)
-// use cluster of 1 node that has data + master roles
-@ESIntegTestCase.ClusterScope(scope = SUITE, numDataNodes = 1, supportsDedicatedMasters = false)
-public class ElasticsearchIOTest extends ESIntegTestCase implements Serializable {
+public class ElasticsearchIOTest implements Serializable {

Review comment:
       @timrobertson100 +1 I agree, I'd love to see the test files consolidated if that were possible. Also +1 on that being a separate jira 😝 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org