You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/03 23:21:56 UTC
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5596
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
---
D docs/topics/impala_cdh.xml
M docs/topics/impala_intro.xml
2 files changed, 2 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/5596/1
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 2:
> Patch Set 1: Verified+1
Next time, can you please use http://jenkins.impala.io:8080/view/Gerrit/job/gerrit-docs-submit/ ? If you do not, sooner or later RAT will break which will shut won everyone else's ability to submit changes.
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5596/1/docs/topics/impala_intro.xml
File docs/topics/impala_intro.xml:
Line 73: <title>How Impala Works with <keyword keyref="hadoop_distro"/></title>
Should this generally be made even more generic for users who don't use a distro?
Line 82: <p audience="Cloudera" conref="../shared/impala_common.xml#common/impala_overview_diagram"/>
long line
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5596/1/docs/topics/impala_intro.xml
File docs/topics/impala_intro.xml:
Line 73: <title>How Impala Works with <keyword keyref="hadoop_distro"/></title>
> Should this generally be made even more generic for users who don't use a d
Probably in the end it'll be a different name. I'll defer that to a global search/replace after other cleanup is finished. I have a bunch of other private branches queued up with the original set of keyref= substitution variables.
Line 82: <p audience="Cloudera" conref="../shared/impala_common.xml#common/impala_overview_diagram"/>
> long line
The convention I adhere to is to not split within the same <tag attribute=...> block. Makes searching simpler for idioms such as "tag containing attribute XYZ". There are some verbose tags in DITA, usually centered around references with paths or URLs, where it's impractical to let them split.
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5596/1/docs/topics/impala_cdh.xml
File docs/topics/impala_cdh.xml:
PS1, Line 1:
> are you talking to yourself? :) Worth checking that everyone is logged in a
Yes, just anticipating likely questions from others.
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5596/1/docs/topics/impala_cdh.xml
File docs/topics/impala_cdh.xml:
PS1, Line 1:
> Hey, why'd you delete that whole file?
All the actual content is pulled into the impala_intro topic, so deleting it was a way to reduce duplicate / stale content and get rid of a file with "cdh" in the filename.
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
As a reminder, you can use http://jenkins.impala.io:8080/view/Gerrit/job/gerrit-docs-submit/ to submit your change in a way to ensure it doesn't break the build or RAT.
Let me know if you have any problems or need a password reset.
When that job completes, your change will be in gerrit, but it won't be in the official apache repo yet. You can get it to the official apache repo using the bin/push_to_asf.py script.
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5596/1/docs/topics/impala_cdh.xml
File docs/topics/impala_cdh.xml:
PS1, Line 1:
> All the actual content is pulled into the impala_intro topic, so deleting i
are you talking to yourself? :) Worth checking that everyone is logged in as the person they expect to be...
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5596/1/docs/topics/impala_cdh.xml
File docs/topics/impala_cdh.xml:
PS1, Line 1:
Hey, why'd you delete that whole file?
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has submitted this change and it was merged.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology.
......................................................................
Take out (stale) architecture diagram w/ Cloudera-specific terminology.
Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Reviewed-on: http://gerrit.cloudera.org:8080/5596
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: John Russell <jr...@cloudera.com>
---
D docs/topics/impala_cdh.xml
M docs/topics/impala_intro.xml
2 files changed, 2 insertions(+), 45 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved
John Russell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab3786f113a5492f3aeac7480bfbfdb030cedf5b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>