You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/31 03:04:36 UTC
[GitHub] [maven-build-cache-extension] AlexanderAshitkin opened a new pull request, #34: [MBUILDCACHE-25] Fixes multiple cache processing for forked executions
AlexanderAshitkin opened a new pull request, #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34
Forked execution should be thought as a part of originating mojo internal implementation. If forkedExecution is detected, it means that originating mojo is not cached so fork should rerun too. If originating mojo is cached, it is cached altogether, with forks. The fix detects forked execution and disables cache processing if forked project entered cache.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] maximilian-novikov-db commented on pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by GitBox <gi...@apache.org>.
maximilian-novikov-db commented on PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#issuecomment-1368939370
@gnodet let's merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] gnodet commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1090750483
##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -594,7 +595,7 @@ public String getId()
public String getUrl()
{
checkInitializedState();
- return getRemote().getUrl();
+ return getProperty( REMOTE_URL_PROPERTY_NAME, getRemote().getUrl() );
Review Comment:
Can we split that in a different commit if that's unrelated ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1057397065
##########
pom.xml:
##########
@@ -224,6 +224,22 @@ under the License.
<version>${junitVersion}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.tomakehurst</groupId>
+ <artifactId>wiremock-jre8</artifactId>
+ <version>2.33.1</version>
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by "AlexanderAshitkin (via GitHub)" <gi...@apache.org>.
AlexanderAshitkin commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1115773818
##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -594,7 +595,7 @@ public String getId()
public String getUrl()
{
checkInitializedState();
- return getRemote().getUrl();
+ return getProperty( REMOTE_URL_PROPERTY_NAME, getRemote().getUrl() );
Review Comment:
it is used in the tests to verify the number of executions. it is not unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] maximilian-novikov-db commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by GitBox <gi...@apache.org>.
maximilian-novikov-db commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1021891182
##########
pom.xml:
##########
@@ -224,6 +224,22 @@ under the License.
<version>${junitVersion}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.tomakehurst</groupId>
+ <artifactId>wiremock-jre8</artifactId>
+ <version>2.33.1</version>
Review Comment:
to props?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] olamy commented on pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#issuecomment-1569991299
@AlexanderAshitkin can you resolve conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1057395224
##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -81,6 +81,7 @@ public class CacheConfigImpl implements org.apache.maven.buildcache.xml.CacheCon
public static final String CONFIG_PATH_PROPERTY_NAME = "maven.build.cache.configPath";
public static final String CACHE_ENABLED_PROPERTY_NAME = "maven.build.cache.enabled";
public static final String CACHE_LOCATION_PROPERTY_NAME = "maven.build.cache.location";
+ public static final String REMOTE_URL_PROPERTY_NAME = "maven.build.cache.remoteUrl";
Review Comment:
Yes, with this change is to set remote cache url from command line in integration tests to test remote cache interactions using WireMock. The change allows to use using dynamic WireMock ports to prevent port conflicts in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by "AlexanderAshitkin (via GitHub)" <gi...@apache.org>.
AlexanderAshitkin commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1115773818
##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -594,7 +595,7 @@ public String getId()
public String getUrl()
{
checkInitializedState();
- return getRemote().getUrl();
+ return getProperty( REMOTE_URL_PROPERTY_NAME, getRemote().getUrl() );
Review Comment:
it is used in tests to verify the number of executions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] gnodet commented on pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#issuecomment-1441959491
@AlexanderAshitkin can you resolve the conflicts so that it can be merged ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] gnodet commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1028932294
##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -81,6 +81,7 @@ public class CacheConfigImpl implements org.apache.maven.buildcache.xml.CacheCon
public static final String CONFIG_PATH_PROPERTY_NAME = "maven.build.cache.configPath";
public static final String CACHE_ENABLED_PROPERTY_NAME = "maven.build.cache.enabled";
public static final String CACHE_LOCATION_PROPERTY_NAME = "maven.build.cache.location";
+ public static final String REMOTE_URL_PROPERTY_NAME = "maven.build.cache.remoteUrl";
Review Comment:
Are those changes related to this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1057395224
##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -81,6 +81,7 @@ public class CacheConfigImpl implements org.apache.maven.buildcache.xml.CacheCon
public static final String CONFIG_PATH_PROPERTY_NAME = "maven.build.cache.configPath";
public static final String CACHE_ENABLED_PROPERTY_NAME = "maven.build.cache.enabled";
public static final String CACHE_LOCATION_PROPERTY_NAME = "maven.build.cache.location";
+ public static final String REMOTE_URL_PROPERTY_NAME = "maven.build.cache.remoteUrl";
Review Comment:
Yes, with this change is to set remote cache url from command line and it's currently used in integration tests to test remote cache interactions using WireMock. The change allows to use using dynamic WireMock ports to prevent port conflicts in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] gnodet merged pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org