You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/10 23:32:12 UTC

[GitHub] eolivelli commented on issue #1245: Collect Prometheus latency stats using DataSketches

eolivelli commented on issue #1245: Collect Prometheus latency stats using DataSketches
URL: https://github.com/apache/bookkeeper/pull/1245#issuecomment-372075927
 
 
   @merlimat the change looks good. Great work!
   
   What about adding a minimal test case on the servlet? 
   We will start soon to chase code not covered but testcases, it will be better not to add new code without proper testing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services