[jira] [Commented] (COLLECTIONS-712) ExtendedProperties.save swallows instead of throws IOException

["Philip Hodges (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COLLECTIONS-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879402#comment-16879402 ] 

Philip Hodges commented on COLLECTIONS-712:
-------------------------------------------

Before closing this surely the next action should be to open an issue against the class(es) in commons configuration where it was moved to.
A unit test could dump the configuration to a custom PrintWriter that does not have enough space for it.
And look for similar constructs.


> ExtendedProperties.save swallows instead of throws IOException
> --------------------------------------------------------------
>
>                 Key: COLLECTIONS-712
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-712
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Properties
>    Affects Versions: 3.2.2
>            Reporter: Philip Hodges
>            Priority: Trivial
>
> commons-collections-3.2.2-src/src/java/org/apache/commons/collections/ExtendedProperties.java
> /**
>   * Save the properties to the given output stream.
>   * ...
>   * @throws IOException if an IO error occurs - no it does not.
>   */
> public synchronized void save(OutputStream output, String header) throws IOException {
> ...
> PrintWriter theWrtr = new PrintWriter(output);
>  ...
>  // theWrter.flush();
>  // missing: if (theWrtr.checkError()) throw new IOException();
> Impact: caller cannot tell if the properties were completely saved, perhaps the disk filled up instead. Missing checkError is an antipattern for PrintWriter and PrintStream.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)