You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Sim IJskes - QCG <si...@qcg.nl> on 2009/11/10 16:14:40 UTC

RIVER-325: Use of socket factory in LookupLocator

Peter Firmstone wrote:
> Lets add the constructor, it won't break anything and commit the patch, 
> I've read the patch its straight forward, then we'll run the tests again.
> This is only a trivial change.

I guess you're refering to the patch for RIVER-71. I agree that the 
patch is a trivial change.

For the constructor issue i've opened another, RIVER-325. I will try to 
make the impact of the patch as low as possible. The only concern i have 
with it, is if we expect the locator to be marshalled from one 
participant to another, and when versions differ. The class resides in 
jini-core, so will never be loaded over the network. In this case, we 
should change the serialVersionUID and provide compatibility 
serialization support, and i'm not sure if this will work out ok.

> I'd also like to say thanks for the patch Sim and welcome to Apache River.

Thank you too! :-)

Gr. Sim

-- 
QCG, Software voor het MKB, 071-5890970, http://www.qcg.nl
Quality Consultancy Group b.v., Leiderdorp, Kvk Leiden: 28088397