[GitHub] [gobblin] jack-moseley commented on a diff in pull request #3696: [GOBBLIN-1833]Emit Completeness watermark information in snapshotCommitEvent

["jack-moseley (via GitHub)" <gi...@apache.org>]

jack-moseley commented on code in PR #3696:
URL: https://github.com/apache/gobblin/pull/3696#discussion_r1198342629


##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/MetadataWriterKeys.java:
##########
@@ -31,6 +31,7 @@ public class MetadataWriterKeys {
   public static final String GMCE_TOPIC_NAME = "gmceTopicName";
   public static final String GMCE_TOPIC_PARTITION = "gmceTopicPartition";
   public static final String GMCE_HIGH_WATERMARK = "gmceHighWatermark";
+  public static final String TABLE_COMPLETION_WATERMARK = "tableCompletionWatermark";

Review Comment:
   Let's maybe just use `IcebergMetadataWriterConfigKeys.COMPLETION_WATERMARK_KEY` instead of defining a new key.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org