You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2022/06/19 14:43:11 UTC

[plc4x] 01/02: fix(plc4go): Got the build working with the latest go version by switching from "go get" to "go install" for installing tools.

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git

commit b4d01a79fe5d67716a66cab541929693b3f1b56e
Author: cdutz <ch...@c-ware.de>
AuthorDate: Sun Jun 19 15:05:59 2022 +0200

    fix(plc4go): Got the build working with the latest go version by switching from "go get" to "go install" for installing tools.
---
 plc4go/pom.xml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/plc4go/pom.xml b/plc4go/pom.xml
index b4b9d21a38..0253fd841b 100644
--- a/plc4go/pom.xml
+++ b/plc4go/pom.xml
@@ -37,7 +37,8 @@
     <!-- Tell Sonar where to find the sources -->
     <sonar.sources>examples,internal,pkg,tools</sonar.sources>
     <maven.install.skip>true</maven.install.skip>
-    <maven.deploy.skip>true</maven.deploy.skip>
+    <!-- The deploy goal of the go plugin uses go install to install the result, unfortunately disabling the deploy, disables the go install. -->
+    <!--maven.deploy.skip>true</maven.deploy.skip-->
   </properties>
 
   <build>
@@ -337,7 +338,7 @@
             <id>get-tools</id>
             <phase>initialize</phase>
             <goals>
-              <goal>get</goal>
+              <goal>install</goal>
             </goals>
             <configuration>
               <packages>
@@ -483,7 +484,7 @@
             <id>test-get</id>
             <phase>process-test-resources</phase>
             <goals>
-              <goal>get</goal>
+              <goal>install</goal>
             </goals>
             <configuration>
               <packages>
@@ -563,8 +564,6 @@
           </execution>
         </executions>
         <configuration>
-          <!-- The go get command doesn't seem to work with go 1.18 -->
-          <goVersion>1.17.11</goVersion>
           <packages>
             <package>github.com/apache/plc4x/plc4go/pkg/api</package>
           </packages>