You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ha...@apache.org on 2015/09/28 20:37:04 UTC
hive git commit: HIVE-11590 : AvroDeserializer is very chatty
(Swarnim Kulkarni via Xuefu Zhang)
Repository: hive
Updated Branches:
refs/heads/master 0463b7ad8 -> ea05d3d4b
HIVE-11590 : AvroDeserializer is very chatty (Swarnim Kulkarni via Xuefu Zhang)
Signed-off-by: Ashutosh Chauhan <ha...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/ea05d3d4
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/ea05d3d4
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/ea05d3d4
Branch: refs/heads/master
Commit: ea05d3d4b5349f81d33fed27225af5f161ee7ff8
Parents: 0463b7a
Author: Swarnim Kulkarni <ku...@gmail.com>
Authored: Tue Sep 8 21:59:00 2015 -0800
Committer: Ashutosh Chauhan <ha...@apache.org>
Committed: Mon Sep 28 11:36:43 2015 -0700
----------------------------------------------------------------------
.../hadoop/hive/serde2/avro/AvroDeserializer.java | 2 +-
.../org/apache/hadoop/hive/serde2/avro/AvroSerDe.java | 13 +++++++++----
.../apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java | 7 +++++--
.../apache/hadoop/hive/serde2/avro/AvroSerializer.java | 2 --
4 files changed, 15 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/ea05d3d4/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java
----------------------------------------------------------------------
diff --git a/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java b/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java
index cade8c3..46997f8 100644
--- a/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java
+++ b/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java
@@ -163,7 +163,7 @@ class AvroDeserializer {
reEncoder = new SchemaReEncoder(r.getSchema(), readerSchema);
reEncoderCache.put(recordReaderId, reEncoder);
} else{
- LOG.info("Adding new valid RRID :" + recordReaderId);
+ LOG.debug("Adding new valid RRID :" + recordReaderId);
noEncodingNeeded.add(recordReaderId);
}
if(reEncoder != null) {
http://git-wip-us.apache.org/repos/asf/hive/blob/ea05d3d4/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java
----------------------------------------------------------------------
diff --git a/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java b/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java
index efff663..0e4e4c6 100644
--- a/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java
+++ b/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java
@@ -84,7 +84,7 @@ public class AvroSerDe extends AbstractSerDe {
public void initialize(Configuration configuration, Properties properties) throws SerDeException {
// Reset member variables so we don't get in a half-constructed state
if (schema != null) {
- LOG.info("Resetting already initialized AvroSerDe");
+ LOG.debug("Resetting already initialized AvroSerDe");
}
schema = null;
@@ -110,10 +110,12 @@ public class AvroSerDe extends AbstractSerDe {
properties.setProperty(AvroSerdeUtils.AvroTableProperties.SCHEMA_LITERAL.getPropName(), schema.toString());
}
- LOG.info("Avro schema is " + schema);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Avro schema is " + schema);
+ }
if (configuration == null) {
- LOG.info("Configuration null, not inserting schema");
+ LOG.debug("Configuration null, not inserting schema");
} else {
configuration.set(
AvroSerdeUtils.AvroTableProperties.AVRO_SERDE_SCHEMA.getPropName(), schema.toString(false));
@@ -136,7 +138,10 @@ public class AvroSerDe extends AbstractSerDe {
//Comments are separated by "\0" in columnCommentProperty, see method getSchema
//in MetaStoreUtils where this string columns.comments is generated
columnComments = Arrays.asList(columnCommentProperty.split("\0"));
- LOG.info("columnComments is " + columnCommentProperty);
+
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("columnComments is " + columnCommentProperty);
+ }
}
if (columnNames.size() != columnTypes.size()) {
throw new IllegalArgumentException("AvroSerde initialization failed. Number of column " +
http://git-wip-us.apache.org/repos/asf/hive/blob/ea05d3d4/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java
----------------------------------------------------------------------
diff --git a/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java b/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java
index 903ac95..a451601 100644
--- a/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java
+++ b/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java
@@ -153,8 +153,11 @@ public class AvroSerdeUtils {
fs = FileSystem.get(new URI(schemaFSUrl), conf);
} catch (IOException ioe) {
//return null only if the file system in schema is not recognized
- String msg = "Failed to open file system for uri " + schemaFSUrl + " assuming it is not a FileSystem url";
- LOG.debug(msg, ioe);
+ if (LOG.isDebugEnabled()) {
+ String msg = "Failed to open file system for uri " + schemaFSUrl + " assuming it is not a FileSystem url";
+ LOG.debug(msg, ioe);
+ }
+
return null;
}
try {
http://git-wip-us.apache.org/repos/asf/hive/blob/ea05d3d4/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java
----------------------------------------------------------------------
diff --git a/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java b/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java
index 866c33d..1c8bc48 100644
--- a/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java
+++ b/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java
@@ -56,8 +56,6 @@ import org.apache.hadoop.hive.serde2.typeinfo.UnionTypeInfo;
import org.apache.hadoop.io.Writable;
class AvroSerializer {
- private static final Log LOG = LogFactory.getLog(AvroSerializer.class);
-
/**
* The Schema to use when serializing Map keys.
* Since we're sharing this across Serializer instances, it must be immutable;