You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/03 16:04:20 UTC
[GitHub] [spark] srowen commented on a change in pull request #28112:
[SPARK-31315][SQL][FOLLOWUP][MINOR] Fix some typo and improve comments.
srowen commented on a change in pull request #28112: [SPARK-31315][SQL][FOLLOWUP][MINOR] Fix some typo and improve comments.
URL: https://github.com/apache/spark/pull/28112#discussion_r403109579
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1309,9 +1309,9 @@ object CodeGenerator extends Logging {
// bytecode instruction
final val MUTABLESTATEARRAY_SIZE_LIMIT = 32768
- // The java source code generated by whole codegen is compiled on the Driver side and sent to
- // each Executor as the execution code to process data. This is very effective in processing
- // large amounts of data in a distributed environment. However, in the test environment,
+ // The Java source code generated by whole-stage codegen on the Driver side is sent to each
Review comment:
So it's generated on the driver and compiled on the executor, you're sure? seems OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org