You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/28 12:33:00 UTC
[jira] [Commented] (GEODE-2886) The WaitUntilFlushedFunction throws
an IllegalArgumentException instead of an IllegalStateException
[ https://issues.apache.org/jira/browse/GEODE-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066413#comment-16066413 ]
ASF GitHub Bot commented on GEODE-2886:
---------------------------------------
GitHub user ameybarve15 opened a pull request:
https://github.com/apache/geode/pull/609
GEODE-2886 : sent IllegalStateException instead of throwing IllegalArgumentException inside WaitUntilFlushedFunction
1. sent IllegalStateException instead of throwing IllegalArgumentException inside WaitUntilFlushedFunction
2. Added dunit test with invalid indexName to get IllegalStateException
to the caller of the WaitUntilFlushedFunction.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameybarve15/incubator-geode feature/GEODE-2886
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/609.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #609
----
commit f9c81c20fdb033ac5d90baae0f8a22aba5952a8b
Author: Amey Barve <ab...@apache.org>
Date: 2017-06-23T10:48:33Z
GEODE-2886 : 1. sent IllegalStateException instead of throwing
IllegalArgumentException inside WaitUntilFlushedFunction.
2. Added dunit test with invalid indexName to get IllegalStateException
to the caller of the WaitUntilFlushedFunction.
commit 6057e5b66c301b0034861639e80889c210559a3c
Author: Amey Barve <ab...@apache.org>
Date: 2017-06-28T08:52:39Z
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into feature/GEODE-2886
----
> The WaitUntilFlushedFunction throws an IllegalArgumentException instead of an IllegalStateException
> ---------------------------------------------------------------------------------------------------
>
> Key: GEODE-2886
> URL: https://issues.apache.org/jira/browse/GEODE-2886
> Project: Geode
> Issue Type: Bug
> Components: lucene
> Reporter: Barry Oglesby
> Assignee: Amey Barve
>
> When the AEQ doesn't exist, the WaitUntilFlushedFunction throws an IllegalArgumentException like:
> {noformat}
> Caused by: java.lang.IllegalArgumentException: The AEQ does not exist for the index xxx region /yyy
> at org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction.execute(WaitUntilFlushedFunction.java:89)
> at org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333)
> {noformat}
> The arguments are actually fine so should it instead throw an IllegalStateException?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)