You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/05/19 15:25:26 UTC

svn commit: r1831902 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java

Author: tilman
Date: Sat May 19 15:25:26 2018
New Revision: 1831902

URL: http://svn.apache.org/viewvc?rev=1831902&view=rev
Log:
PDFBOX-3353: update //TODO comment because a part was done in previous commit

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java?rev=1831902&r1=1831901&r2=1831902&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java Sat May 19 15:25:26 2018
@@ -149,15 +149,10 @@ public class PDPolylineAppearanceHandler
                     }
                 }
                 //TODO line endings (LE) are missing
-                // How it could be done by reusing some of the code from 
-                // the Line and StrikeOut handlers
-                // 1) if the LE is contained in SHORT_STYLES, 
-                // shorten the first + last arms with "this weird old trick"
-                // used in the StrikeOut handler
-                // and paint
-                // 2) do a transform so that first and last arms are imagined flat
-                // (like in Line handler)
-                // 3) refactor + reuse the line handler code that draws the ending shapes
+                // How it could be done by reusing some of the code from the line handler
+                // 1) do a transform so that first and last "arms" are imagined flat
+                // (like in line handler)
+                // 2) refactor + reuse the line handler code that draws the ending shapes
                 // the alternative would be to apply the transform to the LE shapes directly,
                 // which would be more work and produce code difficult to understand
                 cs.stroke();