[GitHub] [beam] lostluck commented on a change in pull request #13115: Update go protocol buffers to v2.

[GitBox <gi...@apache.org>]

lostluck commented on a change in pull request #13115:
URL: https://github.com/apache/beam/pull/13115#discussion_r508016369



##########
File path: model/pipeline/src/main/proto/standard_window_fns.proto
##########
@@ -25,7 +25,7 @@ syntax = "proto3";
 
 package org.apache.beam.model.pipeline.v1;
 
-option go_package = "pipeline_v1";
+option go_package = "github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1;pipeline_v1";

Review comment:
       This is valid, but it's not go, it's proto option syntax. Unfortunately it's only used in places and never fully described AFAICT and I don't want to dig into the C++ source to find out.
   
   You can see an example of it here, and search for "go_package": https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.descriptor.pb?hl=en




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org