You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/07/04 02:54:03 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2953: Support to interrupt the thrift request if remote engine is broken

yaooqinn commented on code in PR #2953:
URL: https://github.com/apache/incubator-kyuubi/pull/2953#discussion_r912591136


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala:
##########
@@ -56,6 +58,24 @@ class KyuubiSyncThriftClient private (
   private var engineAliveThreadPool: ScheduledExecutorService = _
   @volatile private var engineLastAlive: Long = _
 
+  private var asyncRequestExecutor: ScheduledExecutorService = _

Review Comment:
   Use something like com.google.common.util.concurrent.MoreExecutors#sameThreadExecutor？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org