You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/06/27 13:21:48 UTC
[GitHub] [hive] lcspinter commented on a diff in pull request #3401: HIVE-26354: Support expiring snapshots on iceberg table
lcspinter commented on code in PR #3401:
URL: https://github.com/apache/hive/pull/3401#discussion_r907379084
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/execute/AlterTableExecuteAnalyzer.java:
##########
@@ -72,14 +75,26 @@ protected void analyzeCommand(TableName tableName, Map<String, String> partition
ZoneId timeZone = SessionState.get() == null ? new HiveConf().getLocalTimeZone() : SessionState.get().getConf()
.getLocalTimeZone();
TimestampTZ time = TimestampTZUtil.parse(PlanUtils.stripQuotes(child.getText()), timeZone);
- spec = new AlterTableExecuteSpec(ROLLBACK, new AlterTableExecuteSpec.RollbackSpec(TIME, time.toEpochMilli()));
+ spec = new AlterTableExecuteSpec(ROLLBACK, new RollbackSpec(TIME, time.toEpochMilli()));
} else {
- spec = new AlterTableExecuteSpec(ROLLBACK, new AlterTableExecuteSpec.RollbackSpec(VERSION,
+ spec = new AlterTableExecuteSpec(ROLLBACK, new RollbackSpec(VERSION,
Long.valueOf(child.getText())));
}
desc = new AlterTableExecuteDesc(tableName, partitionSpec, spec);
}
+ if (HiveParser.KW_EXPIRE_SNAPSHOTS == executeCommandType.getType()) {
Review Comment:
nit: from a readability perspective else if statement would be better
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTableExecuteSpec.java:
##########
@@ -25,13 +25,15 @@
* The following operation are supported
Review Comment:
nit: operations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org