[GitHub] [druid] rohangarg commented on a change in pull request #11316: Fix Index hadoop failing with index.zip is not a valid DFS filename

[GitBox <gi...@apache.org>]

rohangarg commented on a change in pull request #11316:
URL: https://github.com/apache/druid/pull/11316#discussion_r641938894



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java
##########
@@ -550,13 +545,8 @@ private void renameSegmentIndexFilesJob(
       String dataSegmentAndIndexZipFilePathListStr
   )
   {
-    final ClassLoader oldLoader = Thread.currentThread().getContextClassLoader();
+    final ClassLoader loader = Thread.currentThread().getContextClassLoader();
     try {
-      ClassLoader loader = HadoopTask.buildClassLoader(
-          getHadoopDependencyCoordinates(),
-          taskConfig.getDefaultHadoopCoordinates()
-      );
-
       Object renameSegmentIndexFilesRunner = getForeignClassloaderObject(

Review comment:
       why do we not want to use the custom hadoop classloader? also, does this make sense since we're now using the current classloader itself?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org