You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pdyraga <gi...@git.apache.org> on 2017/10/18 07:27:53 UTC
[GitHub] cordova-plugin-splashscreen pull request #137: CB-13460: Apply Android style...
GitHub user pdyraga opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/137
CB-13460: Apply Android style to the splash screen
This change makes the splash screen dialog use the `SplashScreenStyle`, if defined.
If not, it falls back to the default style.
Using Android style is a way more robust than adding configurable status/navigation color properties.
Examples:
In the `config.xml`:
```
<resource-file src="my-android-theme.xml" target="res/values/themes.xml" />
```
In the `my-android-theme.xml`:
```
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="SplashScreenStyle">
<item name="android:windowFullscreen">true</item>
<item name="android:windowTranslucentNavigation">true</item>
</style>
</resources>
```
```
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="SplashScreenStyle">
<item name="android:statusBarColor">@android:color/holo_green_light</item>
<item name="android:navigationBarColor">@android:color/holo_green_light</item>
</style>
</resources>
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdyraga/cordova-plugin-splashscreen master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit 143b63eda15f11a3de1a198dc63f84e09ed2e4e8
Author: Piotr Dyraga <pi...@ontheserverside.com>
Date: 2017-10-18T06:40:33Z
Apply an Android Style to the splash screen
Cordova 6.4.0 adds `edit-config` support to `config.xml`. This lets to easily define custom Android styles.
This change makes the splash screen dialog use the `SplashScreenStyle`, if defined.
If not, it falls back to the default style.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #137: CB-13460: Apply Android style to the...
Posted by pdyraga <gi...@git.apache.org>.
Github user pdyraga commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/137
Some tests failed but it looks like some test environment issue rather than a problem with the code here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org