You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/06/06 05:53:45 UTC
[GitHub] jvrao commented on a change in pull request #1436: BP-14 force()
API - client side implementation
jvrao commented on a change in pull request #1436: BP-14 force() API - client side implementation
URL: https://github.com/apache/bookkeeper/pull/1436#discussion_r193298274
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DistributionSchedule.java
##########
@@ -149,6 +149,13 @@ public WriteSet copy() {
*/
WriteSet getWriteSetForLongPoll(long entryId);
+ /**
+ * Return the set of bookies indices to send the messages to for force ledger.
+ *
+ * @return the set of bookies indices to send force request to.
+ */
+ WriteSet getWriteSetForForceLedger();
Review comment:
I like that idea; Everything that needs to get whole ensemble set can have one API. maybe call it `getEnsembleSet`, no need to have **write** in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services